Bindiff: remove time.sleep()

[montyly]

https://github.com/trailofbits/ethersplay/blob/5b329b122351af6aba53098d15cb5e501b2f3a30/ethersplay/bindiff.py#L136-L137

view_diff.update_analysis_and_wait() does not wait for the end of the update. Find how to wait without having the main thread sleeping.

[joshwatson]

You're going to have trouble doing this easily, because update_analysis_and_wait() is going to return as soon as the first analysis pass completes, which is prior to the initial analysis is kicked off by the BinaryView. What you should probably do is consider using an AnalysisCompletionEvent or a BinaryDataNotification callback.