Merge pull request #853 from crytic/dev-improve-upgradeability

Relax detection of initialization functions

Author: montyly

slither/tools/upgradeability/checks/initialization.py

@@ -1,5 +1,6 @@
 import logging
 
+from slither.core.declarations import Function
 from slither.slithir.operations import InternalCall
 from slither.tools.upgradeability.checks.abstract_checks import (
     AbstractCheck,
@@ -14,8 +15,18 @@ class MultipleInitTarget(Exception):
     pass
 
 
+def _has_initiliaze_modifier(function: Function):
+    if not function.modifiers:
+        return False
+    return any((m.name == "initializer") for m in function.modifiers)
+
+
 def _get_initialize_functions(contract):
-    return [f for f in contract.functions if f.name == "initialize" and f.is_implemented]
+    return [
+        f
+        for f in contract.functions
+        if (f.name == "initialize" or _has_initiliaze_modifier(f)) and f.is_implemented
+    ]
 
 
 def _get_all_internal_calls(function):