Merge branch 'dev' of github.com:crytic/slither into dev

Author: montyly

slither/detectors/compiler_bugs/public_mapping_nested.py

@@ -72,9 +72,9 @@ def _detect(self):
         """
         results = []
 
-        for p in self.compilation_unit.pragma_directives:
-            if "0.5.0" in p.version and not "<0.5.0" in p.version:
-                return []
+        if self.compilation_unit.solc_version >= "0.5.0":
+            return []
+
         if self.compilation_unit.solc_version and self.compilation_unit.solc_version.startswith(
             "0.5."
         ):

slither/slithir/convert.py

@@ -772,6 +772,17 @@ def extract_tmp_call(ins, contract):  # pylint: disable=too-many-locals
                 op.set_expression(ins.expression)
                 op.call_id = ins.call_id
                 return op
+
+            # For event emit through library
+            # lib L { event E()}
+            # ...
+            # emit L.E();
+            if str(ins.ori.variable_right) in [f.name for f in ins.ori.variable_left.events]:
+                eventcall = EventCall(ins.ori.variable_right)
+                eventcall.set_expression(ins.expression)
+                eventcall.call_id = ins.call_id
+                return eventcall
+
             libcall = LibraryCall(
                 ins.ori.variable_left,
                 ins.ori.variable_right,

slither/solc_parsing/expressions/expression_parsing.py

@@ -892,7 +892,12 @@ def parse_expression(expression: Dict, caller_context: CallerContext) -> "Expres
                     array_type = ElementaryType(type_name["attributes"]["name"])
             elif type_name[caller_context.get_key()] == "UserDefinedTypeName":
                 if is_compact_ast:
-                    array_type = parse_type(UnknownType(type_name["name"]), caller_context)
+                    if "name" not in type_name:
+                        name_type = type_name["pathNode"]["name"]
+                    else:
+                        name_type = type_name["name"]
+
+                    array_type = parse_type(UnknownType(name_type), caller_context)
                 else:
                     array_type = parse_type(
                         UnknownType(type_name["attributes"]["name"]), caller_context