Fix reverse debugging commands (#365)

* Pin mypy to 0.782

* Fix reverse debugging commands

* Bump version to 0.14.0.2

Author: loganwendholt

CHANGELOG.md

@@ -1,5 +1,10 @@
 # gdbgui release history
 
+## 0.14.0.2
+
+- Pinned mypy version to unbreak linting
+- Fixed reverse debugging commands that were broken when `--gdb` flag was removed
+
 ## 0.14.0.1
 
 - Fix import paths

gdbgui/VERSION.txt

@@ -1 +1 @@
-0.14.0.1
+0.14.0.2

gdbgui/src/js/ControlButtons.tsx

@@ -11,7 +11,7 @@ class ControlButtons extends React.Component<{}, State> {
     // @ts-expect-error ts-migrate(2554) FIXME: Expected 1-2 arguments, but got 0.
     super();
     // @ts-expect-error ts-migrate(2339) FIXME: Property 'connectComponentState' does not exist on... Remove this comment to see the full error message
-    store.connectComponentState(this, ["gdb_pid"]);
+    store.connectComponentState(this, ["gdb_pid", "reverse_supported"]);
   }
   render() {
     let btn_class = "btn btn-default btn-sm";
@@ -34,8 +34,7 @@ class ControlButtons extends React.Component<{}, State> {
           type="button"
           title={
             "Continue until breakpoint is hit or inferior program exits keyboard shortcut: c" +
-            // @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.
-            (initial_data.rr ? ". shift + c for reverse." : "")
+            (this.state.reverse_supported ? ". shift + c for reverse." : "")
           }
           className={btn_class}
         >
@@ -57,8 +56,7 @@ class ControlButtons extends React.Component<{}, State> {
           type="button"
           title={
             "Step over next function call keyboard shortcut: n or right arrow" +
-            // @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.
-            (initial_data.rr ? ". shift + n for reverse." : "")
+            (this.state.reverse_supported ? ". shift + n for reverse." : "")
           }
           className={btn_class}
         >
@@ -71,8 +69,7 @@ class ControlButtons extends React.Component<{}, State> {
           type="button"
           title={
             "Step into next function call keyboard shortcut: s or down arrow" +
-            // @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.
-            (initial_data.rr ? ". shift + s for reverse." : "")
+            (this.state.reverse_supported ? ". shift + s for reverse." : "")
           }
           className={btn_class}
         >
@@ -95,8 +92,7 @@ class ControlButtons extends React.Component<{}, State> {
             type="button"
             title={
               "Next Instruction: Execute one machine instruction, stepping over function calls keyboard shortcut: m" +
-              // @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.
-              (initial_data.rr ? ". shift + m for reverse." : "")
+              (this.state.reverse_supported ? ". shift + m for reverse." : "")
             }
             className="btn btn-default"
           >
@@ -108,8 +104,7 @@ class ControlButtons extends React.Component<{}, State> {
             type="button"
             title={
               "Step Instruction: Execute one machine instruction, stepping into function calls keyboard shortcut: ','" +
-              // @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.
-              (initial_data.rr ? ". shift + , for reverse." : "")
+              (this.state.reverse_supported ? ". shift + , for reverse." : "")
             }
             className="btn btn-default"
           >

gdbgui/src/js/GlobalEvents.ts

@@ -4,6 +4,7 @@
 
 import constants from "./constants";
 import GdbApi from "./GdbApi";
+import { store } from "statorgfc";
 
 const GlobalEvents = {
   init: function() {
@@ -45,9 +46,10 @@ const GlobalEvents = {
         GdbApi.click_next_instruction_button(e.shiftKey);
       } else if (e.keyCode === constants.COMMA_BUTTON_NUM) {
         GdbApi.click_step_instruction_button(e.shiftKey);
-        // @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.
-      } else if (initial_data.rr && e.keyCode === constants.LEFT_BUTTON_NUM) {
-        // reverse
+      } else if (
+        e.keyCode === constants.LEFT_BUTTON_NUM &&
+        store.get("reverse_supported")
+      ) {
         GdbApi.click_next_button(true);
       }
     }

gdbgui/src/js/InitialStoreData.ts

@@ -23,6 +23,7 @@ const initial_store_data = {
   show_settings: false,
 
   debug_in_reverse: false,
+  reverse_supported: false,
   show_modal: false,
   modal_header: null,
   modal_body: null,

gdbgui/src/js/TopBar.tsx

@@ -175,6 +175,7 @@ class TopBar extends React.Component<{}, State> {
       this,
       [
         "debug_in_reverse",
+        "reverse_supported",
         "source_code_state",
         "waiting_for_response",
         "show_filesystem",
@@ -303,30 +304,27 @@ class TopBar extends React.Component<{}, State> {
       );
     }
 
-    let reverse_checkbox = null;
-    // @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.
-    if (initial_data.rr) {
-      reverse_checkbox = (
-        <label
-          title={
-            "when clicking buttons to the right, pass the `--reverse` " +
-            "flag to gdb in an attempt to debug in reverse. This is not always supported. " +
-            "rr is known to support reverse debugging. Keyboard shortcuts go in " +
-            "reverse when pressed with the shift key."
-          }
-          style={{ fontWeight: "normal", fontSize: "0.9em", margin: "5px" }}
-        >
-          <input
-            type="checkbox"
-            checked={store.get("debug_in_reverse")}
-            onChange={e => {
-              store.set("debug_in_reverse", e.target.checked);
-            }}
-          />
-          reverse
-        </label>
-      );
-    }
+    let reverse_checkbox = (
+      <label
+        title={
+          "when clicking buttons to the right, pass the `--reverse` " +
+          "flag to gdb in an attempt to debug in reverse. This is not always supported. " +
+          "rr is known to support reverse debugging. Keyboard shortcuts go in " +
+          "reverse when pressed with the shift key."
+        }
+        style={{ fontWeight: "normal", fontSize: "0.9em", margin: "5px" }}
+      >
+        <input
+          type="checkbox"
+          disabled={!this.state.reverse_supported}
+          checked={store.get("debug_in_reverse")}
+          onChange={e => {
+            store.set("debug_in_reverse", e.target.checked);
+          }}
+        />
+        reverse
+      </label>
+    );
 
     return (
       <div

gdbgui/src/js/processFeatures.ts

@@ -19,6 +19,6 @@ type Feature =
 
 export function processFeatures(features: Array<Feature>) {
   if (features.indexOf("reverse") !== -1) {
-    store.set("debug_in_reverse", true);
+    store.set("reverse_supported", true);
   }
 }

noxfile.py

@@ -19,7 +19,13 @@
 ]
 
 doc_dependencies = [".", "mkdocs", "mkdocs-material"]
-lint_dependencies = ["black==20.8b1", "vulture", "flake8", "mypy", "check-manifest"]
+lint_dependencies = [
+    "black==20.8b1",
+    "vulture",
+    "flake8",
+    "mypy==0.782",
+    "check-manifest",
+]
 vulture_whitelist = ".vulture_whitelist.py"
 files_to_lint = ["gdbgui", "tests"] + [str(p) for p in Path(".").glob("*.py")]
 files_to_lint.remove(vulture_whitelist)