use pytest (#297)

Chad Smith · web-flow · commit e1d0c121589b · 2019-10-07T18:17:31.000-07:00
* use pytest
diff --git a/.coveragerc b/.coveragerc
@@ -0,0 +1,9 @@
+[report]
+exclude_lines =
+    pragma: no cover
+    def __repr__
+    if self.debug:
+    if settings.DEBUG
+    raise AssertionError
+    raise NotImplementedError
+    if __name__ == .__main__.:
diff --git a/.travis.yml b/.travis.yml
@@ -25,6 +25,9 @@ matrix:
   - python: '3.7'
     env: NOXSESSION="docs"
     dist: xenial
+  - python: '3.8-dev'
+    env: NOXSESSION="tests-3.8"
+    dist: xenial
 
 install:
   # commands for linux
diff --git a/MANIFEST.in b/MANIFEST.in
@@ -13,6 +13,7 @@ prune gdbgui/__pycache__
 
 exclude mypy.ini
 exclude .eslintrc.json
+exclude .coveragerc
 exclude .flake8
 exclude .prettierrc.js
 exclude jest.config.js
diff --git a/noxfile.py b/noxfile.py
@@ -13,11 +13,33 @@
 @nox.session(python=python)
 def tests(session):
     session.install(".")
-    session.run("python", "-m", "unittest", "discover")
+    tests = session.posargs or ["tests"]
+    session.install(".", "pytest", "pytest-cov")
+    tests = session.posargs or ["tests"]
+    session.run(
+        "pytest", "--cov=gdbgui", "--cov-config", ".coveragerc", "--cov-report=", *tests
+    )
+
     session.run("yarn", "install", external=True)
     session.run("yarn", "test", external=True)
     session.run("yarn", "build", external=True)
 
+    session.notify("cover")
+
+
+@nox.session
+def cover(session):
+    """Coverage analysis"""
+    session.install("coverage")
+    session.run(
+        "coverage",
+        "report",
+        "--show-missing",
+        "--omit=gdbgui/SSLify.py",
+        "--fail-under=30",
+    )
+    session.run("coverage", "erase")
+
 
 @nox.session(python="3.7")
 def lint(session):
diff --git a/setup.py b/setup.py
@@ -68,6 +68,7 @@
         "Programming Language :: Python :: 3",
         "Programming Language :: Python :: 3.6",
         "Programming Language :: Python :: 3.7",
+        "Programming Language :: Python :: 3.8",
     ],
     python_requires=">=3.6",
     project_urls={
diff --git a/tests/test_app.py b/tests/test_app.py
diff --git a/tests/test_backend.py b/tests/test_backend.py
@@ -0,0 +1,37 @@
+from gdbgui import backend
+from flask_socketio import send, SocketIO  # type: ignore
+import pytest  # type: ignore
+
+
+backend.setup_backend(testing=True)
+socketio = backend.socketio
+
+
+def test_connect():
+    app = backend.app
+    socketio = SocketIO()
+
+    @socketio.on("connect")
+    def on_connect():
+        send({"connected": "foo"}, json=True)
+
+    socketio.init_app(app, cookie="foo")
+    client = socketio.test_client(app)
+    received = client.get_received()
+    assert len(received) == 1
+    assert received[0]["args"] == {"connected": "foo"}
+
+
+@pytest.fixture
+def test_client():
+    return backend.app.test_client()
+
+
+def test_load_main_page(test_client):
+    response = test_client.get("/")
+    assert response.status_code == 200
+    assert "<!DOCTYPE html>" in response.data.decode()
+
+
+def test_same_port():
+    backend.setup_backend(testing=True)
diff --git a/tests/test_main.py b/tests/test_main.py
@@ -0,0 +1,22 @@
+import gdbgui
+import pytest  # type: ignore
+import sys
+
+
+@pytest.mark.parametrize(
+    "test_argv, init_bin_args, gdb_args",
+    [
+        (["gdbgui"], [], []),
+        (["gdbgui", "--gdb-args", "mybin -myargs"], [], ["mybin", "-myargs"]),
+        (["gdbgui", "--args", "mybin", "-myargs"], ["mybin", "-myargs"], []),
+    ],
+)
+def test_argument_parsing(monkeypatch, test_argv, init_bin_args, gdb_args):
+    def mock_setup_backend(*args, **kwargs):
+        pass
+
+    monkeypatch.setattr(gdbgui.backend, "setup_backend", mock_setup_backend)
+    monkeypatch.setattr(sys, "argv", test_argv)
+    gdbgui.backend.main()
+    assert gdbgui.backend.app.config.get("initial_binary_and_args") == init_bin_args
+    assert gdbgui.backend.app.config.get("gdb_args") == gdb_args
