Skip to content

Commit 8cc4fb2

Browse files
authored
Merge pull request #18 from manics/update-deps
Update xtermjs and socketio
2 parents f4236c0 + 51a15a7 commit 8cc4fb2

File tree

4 files changed

+39
-28
lines changed

4 files changed

+39
-28
lines changed

pyxtermjs/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def pty_input(data):
5050
"""
5151
if app.config["fd"]:
5252
# print("writing to ptd: %s" % data["input"])
53-
os.write(app.config["fd"], data["input"].encode())
53+
os.write(app.config["fd"], data["input"]["key"].encode())
5454

5555

5656
@socketio.on("resize", namespace="/pty")

pyxtermjs/index.html

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
font-family: arial;
88
}
99
</style>
10-
<link rel="stylesheet" href="https://unpkg.com/xterm@3.6.0/dist/xterm.css" />
10+
<link rel="stylesheet" href="https://unpkg.com/xterm@4.11.0/css/xterm.css" />
1111
</head>
1212
<body>
1313

@@ -20,31 +20,32 @@
2020
built by <a href="https://grassfedcode.com">Chad Smith</a> <a href="https://github.com/cs01">GitHub</a>
2121
</p>
2222
<!-- xterm -->
23-
<script src="https://unpkg.com/xterm@3.6.0/dist/xterm.js"></script>
24-
<script src="https://unpkg.com/xterm@3.6.0/dist/addons/fit/fit.js"></script>
25-
<script src="https://unpkg.com/xterm@3.6.0/dist/addons/webLinks/webLinks.js"></script>
26-
<script src="https://unpkg.com/xterm@3.6.0/dist/addons/fullscreen/fullscreen.js"></script>
27-
<script src="https://unpkg.com/[email protected]/dist/addons/search/search.js"></script>
28-
<script src="https://cdnjs.cloudflare.com/ajax/libs/socket.io/2.1.1/socket.io.js"></script>
23+
<script src="https://unpkg.com/xterm@4.11.0/lib/xterm.js"></script>
24+
<script src="https://unpkg.com/xterm[email protected].0/lib/xterm-addon-fit.js"></script>
25+
<script src="https://unpkg.com/xterm[email protected].0/lib/xterm-addon-web-links.js"></script>
26+
<script src="https://unpkg.com/xterm[email protected].0/lib/xterm-addon-sear
27+
ch.js"></script>
28+
<script src="https://cdnjs.cloudflare.com/ajax/libs/socket.io/4.0.1/socket.io.min.js"></script>
2929

3030
<script>
31-
Terminal.applyAddon(fullscreen)
32-
Terminal.applyAddon(fit)
33-
Terminal.applyAddon(webLinks)
34-
Terminal.applyAddon(search)
3531
const term = new Terminal({
3632
cursorBlink: true,
3733
macOptionIsMeta: true,
3834
scrollback: true,
3935
});
36+
// https://github.com/xtermjs/xterm.js/issues/2941
37+
const fit = new FitAddon.FitAddon();
38+
term.loadAddon(fit);
39+
term.loadAddon(new WebLinksAddon.WebLinksAddon());
40+
term.loadAddon(new SearchAddon.SearchAddon());
41+
4042
term.open(document.getElementById('terminal'));
41-
term.fit()
43+
fit.fit()
4244
term.resize(15, 50)
4345
console.log(`size: ${term.cols} columns, ${term.rows} rows`)
44-
// term.toggleFullScreen(true)
45-
term.fit()
46+
fit.fit()
4647
term.write("Welcome to pyxterm.js!\nhttps://github.com/cs01/pyxterm.js\n")
47-
term.on('key', (key, ev) => {
48+
term.onKey((key, ev) => {
4849
console.log("pressed key", key)
4950
console.log("event", ev)
5051
socket.emit("pty-input", {"input": key})
@@ -69,7 +70,7 @@
6970
})
7071

7172
function fitToscreen(){
72-
term.fit()
73+
fit.fit()
7374
socket.emit("resize", {"cols": term.cols, "rows": term.rows})
7475
}
7576

requirements.txt

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,23 @@
44
#
55
# pip-compile
66
#
7-
click==7.0 # via flask
8-
flask-socketio==3.3.1
9-
flask==1.0.2 # via flask-socketio
10-
itsdangerous==1.1.0 # via flask
11-
jinja2==2.10 # via flask
12-
markupsafe==1.1.1 # via jinja2
13-
python-engineio==3.4.3 # via python-socketio
14-
python-socketio==3.1.2 # via flask-socketio
15-
six==1.12.0 # via python-engineio, python-socketio
16-
werkzeug==0.14.1 # via flask
7+
bidict==0.21.2
8+
# via python-socketio
9+
click==7.1.2
10+
# via flask
11+
flask-socketio==5.0.1
12+
# via pyxtermjs (setup.py)
13+
flask==1.1.2
14+
# via flask-socketio
15+
itsdangerous==1.1.0
16+
# via flask
17+
jinja2==2.11.3
18+
# via flask
19+
markupsafe==1.1.1
20+
# via jinja2
21+
python-engineio==4.1.0
22+
# via python-socketio
23+
python-socketio==5.2.1
24+
# via flask-socketio
25+
werkzeug==1.0.1
26+
# via flask

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def get_version() -> str:
5959
extras_require={},
6060
zip_safe=False,
6161
python_requires=">=3.6",
62-
install_requires=["flask-socketio>=3.0, <=4.0"],
62+
install_requires=["flask-socketio>=5.0, <6.0"],
6363
classifiers=[
6464
"Operating System :: OS Independent",
6565
"License :: OSI Approved :: MIT License",

0 commit comments

Comments
 (0)