Skip to content

Commit 9215c52

Browse files
authored
Fixed some logging going to stdout (#5394)
1 parent fdc9f21 commit 9215c52

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Enhancement: Fixed some logging going to stderr
2+
3+
https://github.com/cs3org/reva/pull/5394

internal/grpc/services/spacesregistry/spacesregistry.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ func countTypeFilters(filters []*provider.ListStorageSpacesRequest_Filter) (coun
159159
func (s *service) ListStorageSpaces(ctx context.Context, req *provider.ListStorageSpacesRequest) (*provider.ListStorageSpacesResponse, error) {
160160
user := appctx.ContextMustGetUser(ctx)
161161
filters := req.Filters
162+
log := appctx.GetLogger(ctx)
162163

163164
sp := []*provider.StorageSpace{}
164165
// List all spaces, or look for a specific space

pkg/eosclient/eosgrpc/eoshttp.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import (
3434
"github.com/cs3org/reva/v3/pkg/appctx"
3535
"github.com/cs3org/reva/v3/pkg/eosclient"
3636
"github.com/cs3org/reva/v3/pkg/errtypes"
37-
"github.com/cs3org/reva/v3/pkg/logger"
3837
"github.com/cs3org/reva/v3/pkg/storage"
3938
)
4039

@@ -139,16 +138,11 @@ type EOSHTTPClient struct {
139138

140139
// NewEOSHTTPClient creates a new client with the given options.
141140
func NewEOSHTTPClient(opt *HTTPOptions) (*EOSHTTPClient, error) {
142-
log := logger.New().With().Int("pid", os.Getpid()).Logger()
143-
log.Debug().Str("func", "New").Str("Creating new eoshttp client. opt: ", "'"+fmt.Sprintf("%#v", opt)+"' ").Msg("")
144-
145141
if opt == nil {
146-
log.Debug().Str("opt is nil, error creating http client ", "").Msg("")
147142
return nil, errtypes.InternalError("HTTPOptions is nil")
148143
}
149144

150145
opt.init()
151-
152146
t := &http.Transport{
153147
MaxIdleConns: opt.MaxIdleConns,
154148
MaxConnsPerHost: opt.MaxConnsPerHost,

0 commit comments

Comments
 (0)