Skip to content

Commit 19f6d0a

Browse files
authored
Pass noop tracer from workflow tester
1 parent 8e34002 commit 19f6d0a

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

tester/tester.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import (
2424
"github.com/cschleiden/go-workflows/log"
2525
"github.com/google/uuid"
2626
"github.com/stretchr/testify/mock"
27+
"go.opentelemetry.io/otel/trace"
2728
)
2829

2930
type testHistoryProvider struct {
@@ -118,6 +119,8 @@ type workflowTester[TResult any] struct {
118119
runningActivities int32
119120

120121
logger log.Logger
122+
123+
tracer trace.Tracer
121124
}
122125

123126
type WorkflowTesterOption func(*options)
@@ -154,6 +157,8 @@ func NewWorkflowTester[TResult any](wf interface{}, opts ...WorkflowTesterOption
154157
options.Logger = logger.NewDefaultLogger()
155158
}
156159

160+
tracer := trace.NewNoopTracerProvider().Tracer("workflow-tester")
161+
157162
wt := &workflowTester[TResult]{
158163
options: options,
159164

@@ -176,6 +181,7 @@ func NewWorkflowTester[TResult any](wf interface{}, opts ...WorkflowTesterOption
176181
callbacks: make(chan func() *history.WorkflowEvent, 1024),
177182

178183
logger: options.Logger,
184+
tracer: tracer,
179185
}
180186

181187
// Always register the workflow under test
@@ -246,7 +252,7 @@ func (wt *workflowTester[TResult]) Execute(args ...interface{}) {
246252
tw.pendingEvents = tw.pendingEvents[:0]
247253

248254
// Execute task
249-
e, err := workflow.NewExecutor(wt.logger, wt.registry, &testHistoryProvider{tw.history}, tw.instance, wt.clock)
255+
e, err := workflow.NewExecutor(wt.logger, wt.tracer, wt.registry, &testHistoryProvider{tw.history}, tw.instance, wt.clock)
250256
if err != nil {
251257
panic("could not create workflow executor" + err.Error())
252258
}
@@ -474,7 +480,7 @@ func (wt *workflowTester[TResult]) scheduleActivity(wfi *core.WorkflowInstance,
474480
}
475481

476482
} else {
477-
executor := activity.NewExecutor(wt.logger, wt.registry)
483+
executor := activity.NewExecutor(wt.logger, wt.tracer, wt.registry)
478484
activityResult, activityErr = executor.ExecuteActivity(context.Background(), &task.Activity{
479485
ID: uuid.NewString(),
480486
WorkflowInstance: wfi,

0 commit comments

Comments
 (0)