Merge pull request #287 from decibelcooper/fix_redis_diag_panic

fix: redis diagnostics panic

Author: cschleiden

backend/redis/diagnostics.go

@@ -59,8 +59,13 @@ func (rb *redisBackend) GetWorkflowInstances(ctx context.Context, afterInstanceI
 
 	var instanceRefs []*diag.WorkflowInstanceRef
 	for _, instance := range instances {
+		instStr, ok := instance.(string)
+		if !ok {
+			continue
+		}
+
 		var state instanceState
-		if err := json.Unmarshal([]byte(instance.(string)), &state); err != nil {
+		if err := json.Unmarshal([]byte(instStr), &state); err != nil {
 			return nil, fmt.Errorf("unmarshaling instance state: %w", err)
 		}
 

backend/redis/expire_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/cschleiden/go-workflows/worker"
 	"github.com/cschleiden/go-workflows/workflow"
 	"github.com/google/uuid"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -50,6 +51,11 @@ func Test_AutoExpiration(t *testing.T) {
 	_, err = b.GetWorkflowInstanceState(ctx, wfi)
 	require.ErrorIs(t, err, backend.ErrInstanceNotFound)
 
+	// Check that the instance is gone from the list of instances
+	insts, err := b.(*redisBackend).GetWorkflowInstances(ctx, "", "", 1)
+	require.NoError(t, err)
+	assert.Len(t, insts, 0)
+
 	cancel()
 	require.NoError(t, w.WaitForCompletion())
 }