Merge branch 'main' into fix_redis_diag_panic

Author: decibelcooper

.github/workflows/bench.yml

@@ -68,9 +68,9 @@ jobs:
       - name: Run benchmarks
         run: |
           echo "## Default run" > benchmark.md
-          hyperfine --warmup 1 --export-markdown bench-mysql.md -n 'mysql-main' './bench-main -runs 2 -backend mysql' -n 'mysql-pr' './bench-pr -runs 2 -backend mysql'
-          hyperfine --warmup 1 --export-markdown bench-sqlite.md -n 'sqlite-main' './bench-main -runs 2 -backend sqlite' -n 'sqlite-pr' './bench-pr -runs 2 -backend sqlite'
-          hyperfine --warmup 1 --export-markdown bench-redis.md -n 'redis-main' './bench-main -runs 2 -backend redis' -n 'redis-pr' './bench-pr -runs 2 -backend redis'
+          hyperfine --show-output --warmup 1 --export-markdown bench-mysql.md -n 'mysql-main' './bench-main -runs 2 -backend mysql' -n 'mysql-pr' './bench-pr -runs 2 -backend mysql'
+          hyperfine --show-output --warmup 1 --export-markdown bench-sqlite.md -n 'sqlite-main' './bench-main -runs 2 -backend sqlite' -n 'sqlite-pr' './bench-pr -runs 2 -backend sqlite'
+          hyperfine --show-output --warmup 1 --export-markdown bench-redis.md -n 'redis-main' './bench-main -runs 2 -backend redis' -n 'redis-pr' './bench-pr -runs 2 -backend redis'
           cat bench-mysql.md >> benchmark.md
           echo $'\n' >> benchmark.md
           cat bench-sqlite.md >> benchmark.md
@@ -79,30 +79,29 @@ jobs:
 
       - name: Run large benchmarks
         if: github.event.issue.pull_request && contains(github.event.comment.body, '!large')
-        # hyperfine --show-output --warmup 1 --export-markdown bench-mysql-l.md -n 'mysql-main' './bench-main -resultsize 1000000 -runs 2 -backend mysql -timeout 240s' -n 'mysql-pr' './bench-pr -resultsize 1000000 -runs 2 -backend mysql -timeout 240s'
-        # hyperfine --show-output --warmup 1 --export-markdown bench-sqlite-l.md -n 'sqlite-main' './bench-main -resultsize 1000000 -runs 2 -backend sqlite -timeout 240s' -n 'sqlite-pr' './bench-pr -resultsize 1000000 -runs 2 -backend sqlite -timeout 240s'
-        # cat bench-mysql-l.md >> benchmark.md
-        #   echo $'\n' >> benchmark.md
-        #   cat bench-sqlite-l.md >> benchmark.md
-        #   echo $'\n' >> benchmark.md
         run: |
           echo "## Large payload run (1MB)" >> benchmark.md
-          hyperfine --show-output --warmup 1 --export-markdown bench-redis-l.md -n 'redis-main' './bench-main -resultsize 1000000 -runs 2 -backend redis -timeout 240s' -n 'redis-pr' './bench-pr -resultsize 1000000 -runs 2 -backend redis -timeout 240s'
+          hyperfine --show-output --warmup 1 --export-markdown bench-mysql-l.md -n 'mysql-main' './bench-main -resultsize 1000000 -activities 10 -runs 2 -backend mysql -timeout 240s' -n 'mysql-pr' './bench-pr -resultsize 1000000 -activities 10 -runs 2 -backend mysql -timeout 240s'
+          hyperfine --show-output --warmup 1 --export-markdown bench-sqlite-l.md -n 'sqlite-main' './bench-main -resultsize 1000000 -activities 10 -runs 2 -backend sqlite -timeout 240s' -n 'sqlite-pr' './bench-pr -resultsize 1000000 -activities 10 -runs 2 -backend sqlite -timeout 240s'
+          hyperfine --show-output --warmup 1 --export-markdown bench-redis-l.md -n 'redis-main' './bench-main -resultsize 1000000 -activities 10 -runs 2 -backend redis -timeout 240s' -n 'redis-pr' './bench-pr -resultsize 1000000 -activities 10 -runs 2 -backend redis -timeout 240s'
+          cat bench-mysql-l.md >> benchmark.md
+          echo $'\n' >> benchmark.md
+          cat bench-sqlite-l.md >> benchmark.md
+          echo $'\n' >> benchmark.md
           cat bench-redis-l.md >> benchmark.md
 
-
       - name: Run very large benchmarks
         if: github.event.issue.pull_request && contains(github.event.comment.body, '!verylarge')
-        # hyperfine --show-output --warmup 1 --export-markdown bench-mysql-l.md -n 'mysql-main' './bench-main -resultsize 5000000 -runs 2 -backend mysql -timeout 240s' -n 'mysql-pr' './bench-pr -resultsize 5000000 -runs 2 -backend mysql -timeout 240s'
-        # hyperfine --show-output --warmup 1 --export-markdown bench-sqlite-l.md -n 'sqlite-main' './bench-main -resultsize 5000000 -runs 2 -backend sqlite -timeout 240s' -n 'sqlite-pr' './bench-pr -resultsize 5000000 -runs 2 -backend sqlite -timeout 240s'
-        # cat bench-mysql-l.md >> benchmark.md
-        #   echo $'\n' >> benchmark.md
-        #   cat bench-sqlite-l.md >> benchmark.md
-        #   echo $'\n' >> benchmark.md
         run: |
-          echo "## Large payload run (5MB)" >> benchmark.md
-          hyperfine --show-output --warmup 1 --export-markdown bench-redis-l.md -n 'redis-main' './bench-main -resultsize 5000000 -runs 2 -backend redis -timeout 240s' -n 'redis-pr' './bench-pr -resultsize 5000000 -runs 2 -backend redis -timeout 240s'
-          cat bench-redis-l.md >> benchmark.md
+          echo "## Very Large payload run (5MB)" >> benchmark.md
+          hyperfine --show-output --warmup 1 --export-markdown bench-mysql-vl.md -n 'mysql-main' './bench-main -resultsize 5000000 -runs 2 -backend mysql -timeout 240s' -n 'mysql-pr' './bench-pr -resultsize 5000000 -runs 2 -backend mysql -timeout 240s'
+          hyperfine --show-output --warmup 1 --export-markdown bench-sqlite-vl.md -n 'sqlite-main' './bench-main -resultsize 5000000 -runs 2 -backend sqlite -timeout 240s' -n 'sqlite-pr' './bench-pr -resultsize 5000000 -runs 2 -backend sqlite -timeout 240s'
+          hyperfine --show-output --warmup 1 --export-markdown bench-redis-vl.md -n 'redis-main' './bench-main -resultsize 5000000 -runs 2 -backend redis -timeout 240s' -n 'redis-pr' './bench-pr -resultsize 5000000 -runs 2 -backend redis -timeout 240s'
+          cat bench-mysql-vl.md >> benchmark.md
+          echo $'\n' >> benchmark.md
+          cat bench-sqlite-vl.md >> benchmark.md
+          echo $'\n' >> benchmark.md
+          cat bench-redis-vl.md >> benchmark.md
 
       - name: Write a new comment
         uses: peter-evans/create-or-update-comment@v2

.github/workflows/go.yml

@@ -35,7 +35,7 @@ jobs:
 
 
     - name: Test Summary
-      uses: test-summary/action@v1
+      uses: test-summary/action@v2
       with:
         paths: |
           ${{ github.workspace }}/report.xml
@@ -69,7 +69,7 @@ jobs:
         go test -timeout 120s -race -count 1 -v github.com/cschleiden/go-workflows/backend/redis 2>&1 | go-junit-report -set-exit-code -iocopy -out "${{ github.workspace }}/report.xml"
 
     - name: Test Summary
-      uses: test-summary/action@v1
+      uses: test-summary/action@v2
       with:
         paths: |
           ${{ github.workspace }}/report.xml
@@ -95,7 +95,7 @@ jobs:
         go test -timeout 120s -race -count 1 -v github.com/cschleiden/go-workflows/backend/sqlite 2>&1 | go-junit-report -set-exit-code -iocopy -out "${{ github.workspace }}/report.xml"
 
     - name: Test Summary
-      uses: test-summary/action@v1
+      uses: test-summary/action@v2
       with:
         paths: |
           ${{ github.workspace }}/report.xml
@@ -124,7 +124,7 @@ jobs:
         go test -timeout 120s -race -count 1 -v github.com/cschleiden/go-workflows/backend/mysql 2>&1 | go-junit-report -set-exit-code -iocopy -out "${{ github.workspace }}/report.xml"
 
     - name: Test Summary
-      uses: test-summary/action@v1
+      uses: test-summary/action@v2
       with:
         paths: |
           ${{ github.workspace }}/report.xml

.vscode/settings.json

@@ -1,13 +1,6 @@
 {
   // Some integration tests take quite long to run, increase the overall limit for now
   "go.testFlags": ["-timeout", "120s", "-race", "-count", "1"], // , "-short"],
-  "workbench.colorCustomizations": {
-    "titleBar.activeBackground": "#007fff",
-    "titleBar.activeForeground": "#e7e7e7",
-    "titleBar.inactiveBackground": "#007fff99",
-    "titleBar.inactiveForeground": "#e7e7e799",
-  },
-
   "files.exclude": {
     "**/.git": true,
     "**/.svn": true,
@@ -17,14 +10,9 @@
     "**/Thumbs.db": true,
     "**/vendor": true,
   },
-  "gopls": {
-    "ui.semanticTokens": true,
-  },
   "github-actions.workflows.pinned.workflows": [
     ".github/workflows/go.yml"
   ],
   "go.testExplorer.showDynamicSubtestsInEditor": true,
   "go.lintTool": "golangci-lint",
-  "todo-tree.tree.showBadges": true,
-  "todo-tree.tree.disableCompactFolders": true
 }

README.md

@@ -125,7 +125,7 @@ For all backends, for now the initial schema is applied upon first usage. In the
 
 #### Sqlite
 
-The Sqlite backend implementation supports two different modes, in-memory and on-disk.
+The Sqlite backend implementation supports two different modes, in-memory and on-disk:
 
  * In-memory:
 	```go
@@ -136,12 +136,16 @@ The Sqlite backend implementation supports two different modes, in-memory and on
 	b := sqlite.NewSqliteBackend("simple.sqlite")
 	```
 
+By default the schema is automatically created/migrations are automatically applied. Use `WithApplyMigrations(false)` to disable this behavior.
+
 #### MySql
 
 ```go
 b := mysql.NewMysqlBackend("localhost", 3306, "root", "SqlPassw0rd", "simple")
 ```
 
+By default the schema is automatically created/migrations are automatically applied. Use `WithApplyMigrations(false)` to disable this behavior.
+
 #### Redis
 
 ```go

backend/backend.go

@@ -83,4 +83,7 @@ type Backend interface {
 
 	// ContextPropagators returns the configured context propagators for the backend
 	ContextPropagators() []workflow.ContextPropagator
+
+	// Close closes any underlying resources
+	Close() error
 }

backend/mock_Backend.go

@@ -9,6 +9,7 @@ import (
 	"github.com/cschleiden/go-workflows/backend/history"
 	"github.com/cschleiden/go-workflows/backend/sqlite"
 	"github.com/cschleiden/go-workflows/backend/test"
+	"github.com/stretchr/testify/require"
 )
 
 func Test_MonoprocessBackend(t *testing.T) {
@@ -20,8 +21,10 @@ func Test_MonoprocessBackend(t *testing.T) {
 		// Disable sticky workflow behavior for the test execution
 		options = append(options, backend.WithStickyTimeout(0))
 
-		return NewMonoprocessBackend(sqlite.NewInMemoryBackend(options...))
-	}, nil)
+		return NewMonoprocessBackend(sqlite.NewInMemoryBackend(sqlite.WithBackendOptions(options...)))
+	}, func(b test.TestBackend) {
+		require.NoError(t, b.Close())
+	})
 }
 
 func Test_EndToEndMonoprocessBackend(t *testing.T) {
@@ -33,7 +36,7 @@ func Test_EndToEndMonoprocessBackend(t *testing.T) {
 		// Disable sticky workflow behavior for the test execution
 		options = append(options, backend.WithStickyTimeout(0))
 
-		return NewMonoprocessBackend(sqlite.NewInMemoryBackend(options...))
+		return NewMonoprocessBackend(sqlite.NewInMemoryBackend(sqlite.WithBackendOptions(options...)))
 	}, nil)
 }
 
@@ -43,5 +46,6 @@ func (b *monoprocessBackend) GetFutureEvents(ctx context.Context) ([]*history.Ev
 	if testBackend, ok := b.Backend.(test.TestBackend); ok {
 		return testBackend.GetFutureEvents(ctx)
 	}
+
 	return nil, errors.New("not implemented")
 }

backend/monoprocess/monoprocess_test.go

@@ -0,0 +1,8 @@
+# Sqlite backend
+
+## Adding a migration
+
+1. Install [golang-migrate/migrate](https://www.github.com/golang-migrate/migrate)
+1. ```bash
+   migrate create -ext sql -dir ./db/migrations -seq <name>
+   ```

backend/mysql/README.md

@@ -0,0 +1,4 @@
+DROP TABLE IF EXISTS `instances`;
+DROP TABLE IF EXISTS `pending_events`;
+DROP TABLE IF EXISTS `history`;
+DROP TABLE IF EXISTS `activities`;