Skip to content

Commit 33a43f6

Browse files
committed
Fix linter issues
1 parent 4bf803e commit 33a43f6

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

.golangci.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ linters:
77
enable:
88
- bidichk
99
- bodyclose
10-
- errorlint
1110
- goprintffuncname
1211
- govet
1312
- importas
@@ -22,16 +21,13 @@ linters:
2221
- testifylint
2322
- tparallel
2423
- unconvert
25-
- usetesting
2624
- wastedassign
2725
- whitespace
2826
- unused
2927
# - goworkflows
3028
disable:
3129
- errname
3230
- errcheck
33-
- errorlint
34-
- usetesting
3531
settings:
3632
staticcheck:
3733
checks:

tester/tester_workflowinfo_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func Test_InstanceExecutionDetails_HistoryLength(t *testing.T) {
2121
tester.Execute(context.Background())
2222

2323
require.True(t, tester.WorkflowFinished())
24-
require.Greater(t, capturedLength, int64(0), "History length should be greater than 0")
24+
require.Positive(t, capturedLength, "History length should be greater than 0")
2525
}
2626

2727
func Test_InstanceExecutionDetails_HistoryLength_WithActivity(t *testing.T) {
@@ -48,7 +48,7 @@ func Test_InstanceExecutionDetails_HistoryLength_WithActivity(t *testing.T) {
4848
tester.Execute(context.Background())
4949

5050
require.True(t, tester.WorkflowFinished())
51-
require.Greater(t, lengthBeforeActivity, int64(0))
51+
require.Positive(t, lengthBeforeActivity)
5252
require.Greater(t, lengthAfterActivity, lengthBeforeActivity, "History length should increase after activity execution")
5353

5454
r, err := tester.WorkflowResult()
@@ -89,7 +89,7 @@ func Test_InstanceExecutionDetails_HistoryLength_MultipleSteps(t *testing.T) {
8989

9090
// Get the last 3 values (from the final execution)
9191
finalLengths := lengths[len(lengths)-3:]
92-
require.Greater(t, finalLengths[0], int64(0))
92+
require.Positive(t, finalLengths[0])
9393
require.Greater(t, finalLengths[1], finalLengths[0], "History should grow after first activity")
9494
require.Greater(t, finalLengths[2], finalLengths[1], "History should grow after second activity")
9595
}

workflow/executor/historyinfo_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func Test_InstanceExecutionDetails_SimpleWorkflow(t *testing.T) {
4545
// So history length should be 2
4646
require.Equal(t, int64(2), capturedLength)
4747
require.Equal(t, int64(3), e.lastSequenceID)
48-
require.Equal(t, 3, len(result.Executed)) // WorkflowTaskStarted, WorkflowExecutionStarted, WorkflowExecutionFinished
48+
require.Len(t, result.Executed, 3) // WorkflowTaskStarted, WorkflowExecutionStarted, WorkflowExecutionFinished
4949
}
5050

5151
func Test_InstanceExecutionDetails_WithActivity(t *testing.T) {

0 commit comments

Comments
 (0)