Fix tracking bug when creating >1 sub workflows

cschleiden · web-flow · commit 3ea57c85925c · 2022-04-07T18:07:04.000Z
diff --git a/backend/redis/instance.go b/backend/redis/instance.go
@@ -134,14 +134,9 @@ func createInstance(ctx context.Context, rdb redis.UniversalClient, instance *co
 			return err
 		}
 
-		c, err := rdb.RPush(ctx, subInstanceKey(instance.ParentInstanceID), instanceStr).Result()
-		if err != nil {
+		if err := rdb.RPush(ctx, subInstanceKey(instance.ParentInstanceID), instanceStr).Err(); err != nil {
 			return errors.Wrap(err, "could not track sub-workflow")
 		}
-
-		if c != 1 {
-			return errors.New("could not track sub-workflow")
-		}
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -134,14 +134,9 @@ func createInstance(ctx context.Context, rdb redis.UniversalClient, instance *co`
`134`	`134`	`return err`
`135`	`135`	`}`
`136`	`136`
`137`		`- c, err := rdb.RPush(ctx, subInstanceKey(instance.ParentInstanceID), instanceStr).Result()`
`138`		`- if err != nil {`
	`137`	`+ if err := rdb.RPush(ctx, subInstanceKey(instance.ParentInstanceID), instanceStr).Err(); err != nil {`
`139`	`138`	`return errors.Wrap(err, "could not track sub-workflow")`
`140`	`139`	`}`
`141`		`-`
`142`		`- if c != 1 {`
`143`		`- return errors.New("could not track sub-workflow")`
`144`		`- }`
`145`	`140`	`}`
`146`	`141`
`147`	`142`	`return nil`