Skip to content

Commit 593e289

Browse files
committed
Rename config
1 parent 9e02ddc commit 593e289

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

registry/registry.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,20 @@ type Registry struct {
1818
activityMap map[string]interface{}
1919
}
2020

21+
// New creates a new registry instance.
2122
func New() *Registry {
2223
return &Registry{
2324
workflowMap: make(map[string]wf.Workflow),
2425
activityMap: make(map[string]interface{}),
2526
}
2627
}
2728

28-
type RegisterConfig struct {
29+
type registerConfig struct {
2930
Name string
3031
}
3132

3233
func (r *Registry) RegisterWorkflow(workflow wf.Workflow, opts ...RegisterOption) error {
33-
cfg := registerOptions(opts).applyRegisterOptions(RegisterConfig{})
34+
cfg := registerOptions(opts).applyRegisterOptions(registerConfig{})
3435
name := cfg.Name
3536
if name == "" {
3637
name = fn.Name(workflow)
@@ -75,7 +76,7 @@ func (r *Registry) RegisterWorkflow(workflow wf.Workflow, opts ...RegisterOption
7576
}
7677

7778
func (r *Registry) RegisterActivity(activity wf.Activity, opts ...RegisterOption) error {
78-
cfg := registerOptions(opts).applyRegisterOptions(RegisterConfig{})
79+
cfg := registerOptions(opts).applyRegisterOptions(registerConfig{})
7980

8081
t := reflect.TypeOf(activity)
8182

registry/registry_option.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11
package registry
22

33
type RegisterOption interface {
4-
applyRegisterOption(RegisterConfig) RegisterConfig
4+
applyRegisterOption(registerConfig) registerConfig
55
}
66

77
type registerOptions []RegisterOption
88

9-
func (opts registerOptions) applyRegisterOptions(cfg RegisterConfig) RegisterConfig {
9+
func (opts registerOptions) applyRegisterOptions(cfg registerConfig) registerConfig {
1010
for _, opt := range opts {
1111
cfg = opt.applyRegisterOption(cfg)
1212
}
1313
return cfg
1414
}
1515

16-
type registerOptionFunc func(RegisterConfig) RegisterConfig
16+
type registerOptionFunc func(registerConfig) registerConfig
1717

18-
func (f registerOptionFunc) applyRegisterOption(cfg RegisterConfig) RegisterConfig {
18+
func (f registerOptionFunc) applyRegisterOption(cfg registerConfig) registerConfig {
1919
return f(cfg)
2020
}
2121

2222
func WithName(name string) RegisterOption {
23-
return registerOptionFunc(func(cfg RegisterConfig) RegisterConfig {
23+
return registerOptionFunc(func(cfg registerConfig) registerConfig {
2424
cfg.Name = name
2525
return cfg
2626
})

worker/worker.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ func (w *Worker) Start(ctx context.Context) error {
9393
return nil
9494
}
9595

96+
// WaitForCompletion waits for all active tasks to complete.
9697
func (w *Worker) WaitForCompletion() error {
9798
if err := w.workflowWorker.WaitForCompletion(); err != nil {
9899
return err
@@ -105,10 +106,12 @@ func (w *Worker) WaitForCompletion() error {
105106
return nil
106107
}
107108

109+
// RegisterWorkflow registers a workflow with the worker's registry.
108110
func (w *Worker) RegisterWorkflow(wf workflow.Workflow, opts ...registry.RegisterOption) error {
109111
return w.registry.RegisterWorkflow(wf, opts...)
110112
}
111113

114+
// RegisterActivity registers an activity with the worker's registry.
112115
func (w *Worker) RegisterActivity(a workflow.Activity, opts ...registry.RegisterOption) error {
113116
return w.registry.RegisterActivity(a, opts...)
114117
}

0 commit comments

Comments
 (0)