Skip to content

Commit 63f9db1

Browse files
committed
Skip test for redis backend
1 parent 14f0350 commit 63f9db1

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed

backend/backend.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package backend
33
import (
44
"context"
55
"errors"
6+
"fmt"
67

78
"github.com/cschleiden/go-workflows/backend/history"
89
"github.com/cschleiden/go-workflows/backend/metrics"
@@ -15,6 +16,14 @@ var ErrInstanceNotFound = errors.New("workflow instance not found")
1516
var ErrInstanceAlreadyExists = errors.New("workflow instance already exists")
1617
var ErrInstanceNotFinished = errors.New("workflow instance is not finished")
1718

19+
type ErrNotSupported struct {
20+
Message string
21+
}
22+
23+
func (e ErrNotSupported) Error() string {
24+
return fmt.Sprintf("not supported: %s", e.Message)
25+
}
26+
1827
const TracerName = "go-workflow"
1928

2029
//go:generate mockery --name=Backend --inpackage

backend/redis/instance.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package redis
33
import (
44
"context"
55
"encoding/json"
6-
"errors"
76
"fmt"
87
"time"
98

@@ -159,7 +158,9 @@ func (rb *redisBackend) RemoveWorkflowInstance(ctx context.Context, instance *co
159158
}
160159

161160
func (rb *redisBackend) RemoveWorkflowInstances(ctx context.Context, options ...backend.RemovalOption) error {
162-
return errors.New("not supported, use auto expiration")
161+
return backend.ErrNotSupported{
162+
Message: "not supported, use auto-expiration",
163+
}
163164
}
164165

165166
type instanceState struct {

backend/test/e2e_removal.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package test
22

33
import (
44
"context"
5+
"errors"
56
"testing"
67
"time"
78

@@ -33,6 +34,11 @@ var e2eRemovalTests = []backendTest{
3334
require.NoError(t, err)
3435

3536
err = b.RemoveWorkflowInstances(ctx, backend.RemoveFinishedBefore(now))
37+
if errors.As(err, &backend.ErrNotSupported{}) {
38+
t.Skip()
39+
return
40+
}
41+
3642
require.NoError(t, err)
3743

3844
_, err = c.GetWorkflowInstanceState(ctx, workflowA)

0 commit comments

Comments
 (0)