Make workflow private

Author: cschleiden

workflow/executor/executor.go

@@ -391,7 +391,7 @@ func (e *executor) handleWorkflowExecutionStarted(a *history.ExecutionStartedAtt
 		return fmt.Errorf("workflow %s not found", a.Name)
 	}
 
-	e.workflow = NewWorkflow(reflect.ValueOf(wfFn))
+	e.workflow = newWorkflow(reflect.ValueOf(wfFn))
 
 	return e.workflow.Execute(e.workflowCtx, a.Inputs)
 }

workflow/executor/workflow.go

@@ -19,7 +19,7 @@ type workflow struct {
 	err    error
 }
 
-func NewWorkflow(workflowFn reflect.Value) *workflow {
+func newWorkflow(workflowFn reflect.Value) *workflow {
 	s := sync.NewScheduler()
 
 	return &workflow{

workflow/executor/workflow_test.go

@@ -25,7 +25,7 @@ func Test_Workflow_WrapsPanic(t *testing.T) {
 	ctx := sync.Background()
 	ctx = contextvalue.WithConverter(ctx, converter.DefaultConverter)
 
-	wf := NewWorkflow(reflect.ValueOf(w))
+	wf := newWorkflow(reflect.ValueOf(w))
 	err := wf.Execute(ctx, nil)
 	require.NoError(t, err)