remove todo comment about timer

lovromazgon · lovromazgon · commit a2dcb5dbabc2 · 2023-09-20T13:27:52.000+02:00
diff --git a/backend/monoprocess/monoprocess.go b/backend/monoprocess/monoprocess.go
@@ -113,7 +113,10 @@ func (b *monoprocessBackend) CompleteWorkflowTask(
 			continue
 		}
 		b.logger.DebugContext(ctx, "scheduling timer to notify workflow worker")
-		time.AfterFunc(attr.At.Sub(time.Now()), func() { b.notifyWorkflowWorker(ctx) }) // TODO: cancel timer if the event gets cancelled
+		// Note that the worker will be notified even if the timer event gets
+		// cancelled. This is ok, because the poller will simply find no task
+		// and continue.
+		time.AfterFunc(attr.At.Sub(time.Now()), func() { b.notifyWorkflowWorker(context.Background()) })
 	}
 	for _, e := range workflowEvents {
 		if e.HistoryEvent.Type != history.EventType_WorkflowExecutionStarted &&

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,10 @@ func (b *monoprocessBackend) CompleteWorkflowTask(`
`113`	`113`	`continue`
`114`	`114`	`}`
`115`	`115`	`b.logger.DebugContext(ctx, "scheduling timer to notify workflow worker")`
`116`		`- time.AfterFunc(attr.At.Sub(time.Now()), func() { b.notifyWorkflowWorker(ctx) }) // TODO: cancel timer if the event gets cancelled`
	`116`	`+ // Note that the worker will be notified even if the timer event gets`
	`117`	`+ // cancelled. This is ok, because the poller will simply find no task`
	`118`	`+ // and continue.`
	`119`	`+ time.AfterFunc(attr.At.Sub(time.Now()), func() { b.notifyWorkflowWorker(context.Background()) })`
`117`	`120`	`}`
`118`	`121`	`for _, e := range workflowEvents {`
`119`	`122`	`if e.HistoryEvent.Type != history.EventType_WorkflowExecutionStarted &&`