Executor never fails

Author: cschleiden

internal/worker/workflow.go

@@ -192,11 +192,8 @@ func (ww *WorkflowWorker) getExecutor(ctx context.Context, t *task.Workflow) (wo
 	}
 
 	if !ok {
-		executor, err = workflow.NewExecutor(
+		executor = workflow.NewExecutor(
 			ww.backend.Logger(), ww.backend.Tracer(), ww.registry, ww.backend, t.WorkflowInstance, clock.New())
-		if err != nil {
-			return nil, fmt.Errorf("creating workflow executor: %w", err)
-		}
 	}
 
 	// Cache executor instance for future continuation tasks, or refresh last access time

internal/workflow/cache/cache_test.go

@@ -25,16 +25,14 @@ func Test_Cache_StoreAndGet(t *testing.T) {
 	r.RegisterWorkflow(workflowWithActivity)
 
 	i := core.NewWorkflowInstance("instanceID", "executionID")
-	e, err := wf.NewExecutor(
+	e := wf.NewExecutor(
 		logger.NewDefaultLogger(), trace.NewNoopTracerProvider().Tracer(backend.TracerName), r, &testHistoryProvider{}, i, clock.New())
-	require.NoError(t, err)
 
 	i2 := core.NewWorkflowInstance("instanceID2", "executionID2")
-	e2, err := wf.NewExecutor(
+	e2 := wf.NewExecutor(
 		logger.NewDefaultLogger(), trace.NewNoopTracerProvider().Tracer(backend.TracerName), r, &testHistoryProvider{}, i, clock.New())
-	require.NoError(t, err)
 
-	err = c.Store(context.Background(), i, e)
+	err := c.Store(context.Background(), i, e)
 	require.NoError(t, err)
 
 	re, ok, err := c.Get(context.Background(), i)
@@ -61,11 +59,10 @@ func Test_Cache_Evict(t *testing.T) {
 	i := core.NewWorkflowInstance("instanceID", "executionID")
 	r := wf.NewRegistry()
 	r.RegisterWorkflow(workflowWithActivity)
-	e, err := wf.NewExecutor(
+	e := wf.NewExecutor(
 		logger.NewDefaultLogger(), trace.NewNoopTracerProvider().Tracer(backend.TracerName), r, &testHistoryProvider{}, i, clock.New())
-	require.NoError(t, err)
 
-	err = c.Store(context.Background(), i, e)
+	err := c.Store(context.Background(), i, e)
 	require.NoError(t, err)
 
 	go c.StartEviction(context.Background())

internal/workflow/executor.go

@@ -54,7 +54,7 @@ type executor struct {
 	wfStartedEventSeen bool
 }
 
-func NewExecutor(logger log.Logger, tracer trace.Tracer, registry *Registry, historyProvider WorkflowHistoryProvider, instance *core.WorkflowInstance, clock clock.Clock) (WorkflowExecutor, error) {
+func NewExecutor(logger log.Logger, tracer trace.Tracer, registry *Registry, historyProvider WorkflowHistoryProvider, instance *core.WorkflowInstance, clock clock.Clock) WorkflowExecutor {
 	s := workflowstate.NewWorkflowState(instance, logger, clock)
 
 	wfTracer := workflowtracer.New(tracer)
@@ -80,7 +80,7 @@ func NewExecutor(logger log.Logger, tracer trace.Tracer, registry *Registry, his
 		logger:             logger,
 		tracer:             tracer,
 		wfStartedEventSeen: false,
-	}, nil
+	}
 }
 
 func (e *executor) ExecuteTask(ctx context.Context, t *task.Workflow) (*ExecutionResult, error) {

internal/workflow/executor_test.go

@@ -35,10 +35,7 @@ func newExecutor(r *Registry, i *core.WorkflowInstance, historyProvider Workflow
 	logger := logger.NewDefaultLogger()
 	tracer := trace.NewNoopTracerProvider().Tracer("test")
 
-	e, err := NewExecutor(logger, tracer, r, historyProvider, i, clock.New())
-	if err != nil {
-		panic(err)
-	}
+	e := NewExecutor(logger, tracer, r, historyProvider, i, clock.New())
 
 	return e.(*executor)
 }

tester/tester.go

@@ -252,10 +252,7 @@ func (wt *workflowTester[TResult]) Execute(args ...interface{}) {
 			tw.pendingEvents = tw.pendingEvents[:0]
 
 			// Execute task
-			e, err := workflow.NewExecutor(wt.logger, wt.tracer, wt.registry, &testHistoryProvider{tw.history}, tw.instance, wt.clock)
-			if err != nil {
-				panic("could not create workflow executor" + err.Error())
-			}
+			e := workflow.NewExecutor(wt.logger, wt.tracer, wt.registry, &testHistoryProvider{tw.history}, tw.instance, wt.clock)
 
 			result, err := e.ExecuteTask(context.Background(), t)
 			if err != nil {