Skip to content

Commit b97d19b

Browse files
authored
Merge pull request #156 from zaataylor/remove-unused-field
Remove unused `wfStartedEventSeen` field
2 parents 1130c45 + 50c8c14 commit b97d19b

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

internal/workflow/executor.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ type executor struct {
5151
logger log.Logger
5252
tracer trace.Tracer
5353
lastSequenceID int64
54-
wfStartedEventSeen bool
5554
}
5655

5756
func NewExecutor(logger log.Logger, tracer trace.Tracer, registry *Registry, historyProvider WorkflowHistoryProvider, instance *core.WorkflowInstance, clock clock.Clock) WorkflowExecutor {
@@ -79,7 +78,6 @@ func NewExecutor(logger log.Logger, tracer trace.Tracer, registry *Registry, his
7978
clock: clock,
8079
logger: logger,
8180
tracer: tracer,
82-
wfStartedEventSeen: false,
8381
}
8482
}
8583

@@ -218,14 +216,6 @@ func (e *executor) replayHistory(h []history.Event) error {
218216
return err
219217
}
220218

221-
// If we need to replay history before continuing execution of
222-
// a new task, the executor must know if WorkflowExecutionStarted
223-
// was seen during replay so it can determine if events should
224-
// be reordered before it starts executing events for the new task
225-
if event.Type == history.EventType_WorkflowExecutionStarted {
226-
e.wfStartedEventSeen = true
227-
}
228-
229219
e.lastSequenceID = event.SequenceID
230220
}
231221

0 commit comments

Comments
 (0)