expose GetFutureEvents in sqlite backend

Author: lovromazgon

backend/monoprocess/monoprocess_test.go

@@ -2,12 +2,9 @@ package monoprocess
 
 import (
 	"context"
-	"database/sql"
-	"fmt"
-	"reflect"
+	"errors"
 	"testing"
 	"time"
-	"unsafe"
 
 	"github.com/cschleiden/go-workflows/backend"
 	"github.com/cschleiden/go-workflows/backend/sqlite"
@@ -44,57 +41,8 @@ func Test_EndToEndMonoprocessBackend(t *testing.T) {
 var _ test.TestBackend = (*monoprocessBackend)(nil)
 
 func (b *monoprocessBackend) GetFutureEvents(ctx context.Context) ([]*history.Event, error) {
-	// Reflection hack to access db in private field of sqlite.sqliteBackend
-	privateDbField := reflect.ValueOf(b.Backend).Elem().FieldByName("db")
-	hackedDbField := reflect.NewAt(privateDbField.Type(), unsafe.Pointer(privateDbField.UnsafeAddr())).Elem()
-	db := hackedDbField.Interface().(*sql.DB)
-
-	tx, err := db.BeginTx(ctx, nil)
-	if err != nil {
-		return nil, err
-	}
-	defer tx.Rollback()
-
-	// There is no index on `visible_at`, but this is okay for test only usage.
-	futureEvents, err := tx.QueryContext(
-		ctx,
-		"SELECT id, sequence_id, instance_id, execution_id, event_type, timestamp, schedule_event_id, attributes, visible_at FROM `pending_events` WHERE visible_at IS NOT NULL",
-	)
-	if err != nil {
-		return nil, fmt.Errorf("getting history: %w", err)
-	}
-
-	f := make([]*history.Event, 0)
-
-	for futureEvents.Next() {
-		var instanceID, executionID string
-		var attributes []byte
-
-		fe := &history.Event{}
-
-		if err := futureEvents.Scan(
-			&fe.ID,
-			&fe.SequenceID,
-			&instanceID,
-			&executionID,
-			&fe.Type,
-			&fe.Timestamp,
-			&fe.ScheduleEventID,
-			&attributes,
-			&fe.VisibleAt,
-		); err != nil {
-			return nil, fmt.Errorf("scanning event: %w", err)
-		}
-
-		a, err := history.DeserializeAttributes(fe.Type, attributes)
-		if err != nil {
-			return nil, fmt.Errorf("deserializing attributes: %w", err)
-		}
-
-		fe.Attributes = a
-
-		f = append(f, fe)
+	if testBackend, ok := b.Backend.(test.TestBackend); ok {
+		return testBackend.GetFutureEvents(ctx)
 	}
-
-	return f, nil
+	return nil, errors.New("not implemented")
 }

backend/sqlite/events.go

@@ -7,10 +7,64 @@ import (
 	"strings"
 	"time"
 
+	"github.com/cschleiden/go-workflows/backend/test"
 	"github.com/cschleiden/go-workflows/internal/core"
 	"github.com/cschleiden/go-workflows/internal/history"
 )
 
+var _ test.TestBackend = (*sqliteBackend)(nil)
+
+func (sb *sqliteBackend) GetFutureEvents(ctx context.Context) ([]*history.Event, error) {
+	tx, err := sb.db.BeginTx(ctx, nil)
+	if err != nil {
+		return nil, err
+	}
+	defer tx.Rollback()
+
+	// There is no index on `visible_at`, but this is okay for test only usage.
+	futureEvents, err := tx.QueryContext(
+		ctx,
+		"SELECT id, sequence_id, instance_id, execution_id, event_type, timestamp, schedule_event_id, attributes, visible_at FROM `pending_events` WHERE visible_at IS NOT NULL",
+	)
+	if err != nil {
+		return nil, fmt.Errorf("getting history: %w", err)
+	}
+
+	f := make([]*history.Event, 0)
+
+	for futureEvents.Next() {
+		var instanceID, executionID string
+		var attributes []byte
+
+		fe := &history.Event{}
+
+		if err := futureEvents.Scan(
+			&fe.ID,
+			&fe.SequenceID,
+			&instanceID,
+			&executionID,
+			&fe.Type,
+			&fe.Timestamp,
+			&fe.ScheduleEventID,
+			&attributes,
+			&fe.VisibleAt,
+		); err != nil {
+			return nil, fmt.Errorf("scanning event: %w", err)
+		}
+
+		a, err := history.DeserializeAttributes(fe.Type, attributes)
+		if err != nil {
+			return nil, fmt.Errorf("deserializing attributes: %w", err)
+		}
+
+		fe.Attributes = a
+
+		f = append(f, fe)
+	}
+
+	return f, nil
+}
+
 func getPendingEvents(ctx context.Context, tx *sql.Tx, instance *core.WorkflowInstance) ([]*history.Event, error) {
 	now := time.Now()
 	events, err := tx.QueryContext(

backend/sqlite/sqlite_test.go

@@ -1,13 +1,10 @@
 package sqlite
 
 import (
-	"context"
-	"fmt"
 	"testing"
 
 	"github.com/cschleiden/go-workflows/backend"
 	"github.com/cschleiden/go-workflows/backend/test"
-	"github.com/cschleiden/go-workflows/internal/history"
 )
 
 func Test_SqliteBackend(t *testing.T) {
@@ -35,56 +32,3 @@ func Test_EndToEndSqliteBackend(t *testing.T) {
 		return NewInMemoryBackend(options...)
 	}, nil)
 }
-
-var _ test.TestBackend = (*sqliteBackend)(nil)
-
-func (sb *sqliteBackend) GetFutureEvents(ctx context.Context) ([]*history.Event, error) {
-	tx, err := sb.db.BeginTx(ctx, nil)
-	if err != nil {
-		return nil, err
-	}
-	defer tx.Rollback()
-
-	// There is no index on `visible_at`, but this is okay for test only usage.
-	futureEvents, err := tx.QueryContext(
-		ctx,
-		"SELECT id, sequence_id, instance_id, execution_id, event_type, timestamp, schedule_event_id, attributes, visible_at FROM `pending_events` WHERE visible_at IS NOT NULL",
-	)
-	if err != nil {
-		return nil, fmt.Errorf("getting history: %w", err)
-	}
-
-	f := make([]*history.Event, 0)
-
-	for futureEvents.Next() {
-		var instanceID, executionID string
-		var attributes []byte
-
-		fe := &history.Event{}
-
-		if err := futureEvents.Scan(
-			&fe.ID,
-			&fe.SequenceID,
-			&instanceID,
-			&executionID,
-			&fe.Type,
-			&fe.Timestamp,
-			&fe.ScheduleEventID,
-			&attributes,
-			&fe.VisibleAt,
-		); err != nil {
-			return nil, fmt.Errorf("scanning event: %w", err)
-		}
-
-		a, err := history.DeserializeAttributes(fe.Type, attributes)
-		if err != nil {
-			return nil, fmt.Errorf("deserializing attributes: %w", err)
-		}
-
-		fe.Attributes = a
-
-		f = append(f, fe)
-	}
-
-	return f, nil
-}