Skip to content

Commit cb15064

Browse files
cschleidencschleiden
committed
Remove left-over execution id references
1 parent ffa358c commit cb15064

File tree

8 files changed

+10
-11
lines changed

8 files changed

+10
-11
lines changed

‎README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,7 @@ For logging in workflows, you can get a logger using
575575
logger := workflow.Logger(ctx)
576576
```
577577

578-
The returned `logger` implements the `Logger` interface, and already has the workflow instance and execution IDs set as default fields.
578+
The returned `logger` implements the `Logger` interface, and already has the workflow instance set as default field.
579579

580580
#### Activities
581581

@@ -585,7 +585,7 @@ For logging in activities, you can get a logger using
585585
logger := activity.Logger(ctx)
586586
```
587587

588-
The returned `logger` implements the `Logger` interface, and already has the id of the activity, and the workflow instance and execution IDs set as default fields.
588+
The returned `logger` implements the `Logger` interface, and already has the id of the activity, and the workflow instance set as default field.
589589

590590
### Tracing
591591

‎diag/app/build/asset-manifest.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
{
22
"files": {
33
"main.css": "./static/css/main.8b0db0ad.css",
4-
"main.js": "./static/js/main.6611b79e.js",
4+
"main.js": "./static/js/main.5643d0e0.js",
55
"index.html": "./index.html",
66
"main.8b0db0ad.css.map": "./static/css/main.8b0db0ad.css.map",
7-
"main.6611b79e.js.map": "./static/js/main.6611b79e.js.map"
7+
"main.5643d0e0.js.map": "./static/js/main.5643d0e0.js.map"
88
},
99
"entrypoints": [
1010
"static/css/main.8b0db0ad.css",
11-
"static/js/main.6611b79e.js"
11+
"static/js/main.5643d0e0.js"
1212
]
1313
}

‎diag/app/build/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<!doctype html><html lang="en"><head><meta charset="utf-8"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><title>go-workflows</title><script defer="defer" src="./static/js/main.6611b79e.js"></script><link href="./static/css/main.8b0db0ad.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
1+
<!doctype html><html lang="en"><head><meta charset="utf-8"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><title>go-workflows</title><script defer="defer" src="./static/js/main.5643d0e0.js"></script><link href="./static/css/main.8b0db0ad.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>

‎diag/app/build/static/js/main.6611b79e.js‎ renamed to ‎diag/app/build/static/js/main.5643d0e0.js‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎diag/app/build/static/js/main.6611b79e.js.LICENSE.txt‎ renamed to ‎diag/app/build/static/js/main.5643d0e0.js.LICENSE.txt‎

File renamed without changes.

‎diag/app/build/static/js/main.5643d0e0.js.map‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎diag/app/build/static/js/main.6611b79e.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎internal/command/complete_workflow.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ func (c *CompleteWorkflowCommand) Execute(clock clock.Clock) *CommandResult {
9595

9696
r.WorkflowEvents = []history.WorkflowEvent{
9797
{
98-
// TODO: Do we need execution id here?
9998
WorkflowInstance: core.NewWorkflowInstance(c.Instance.ParentInstanceID),
10099
HistoryEvent: historyEvent,
101100
},

0 commit comments

Comments
 (0)