Remove unused code

Author: cschleiden

backend/redis/events_future.go

@@ -2,71 +2,13 @@ package redis
 
 import (
 	"context"
-	"encoding/json"
 	"fmt"
 	"strconv"
 	"time"
 
-	"github.com/cschleiden/go-workflows/backend/history"
-	"github.com/cschleiden/go-workflows/core"
 	redis "github.com/redis/go-redis/v9"
 )
 
-// Adds an event to be delivered in the future. Not cluster-safe.
-// KEYS[1] - future event zset key
-// KEYS[2] - future event key
-// KEYS[3] - instance payload key
-// ARGV[1] - timestamp/score for set
-// ARGV[2] - Instance segment
-// ARGV[3] - event id
-// ARGV[4] - event data
-// ARGV[5] - event payload
-var addFutureEventCmd = redis.NewScript(`
-	redis.call("ZADD", KEYS[1], ARGV[1], KEYS[2])
-	redis.call("HSET", KEYS[2], "instance", ARGV[2], "id", ARGV[3], "event", ARGV[4])
-	redis.call("HSETNX", KEYS[3], ARGV[3], ARGV[5])
-	return 0
-`)
-
-func addFutureEventP(ctx context.Context, p redis.Pipeliner, instance *core.WorkflowInstance, event *history.Event) error {
-	eventData, err := marshalEventWithoutAttributes(event)
-	if err != nil {
-		return err
-	}
-
-	payloadEventData, err := json.Marshal(event.Attributes)
-	if err != nil {
-		return err
-	}
-
-	return addFutureEventCmd.Run(
-		ctx, p,
-		[]string{futureEventsKey(), futureEventKey(instance, event.ScheduleEventID), payloadKey(instance)},
-		strconv.FormatInt(event.VisibleAt.UnixMilli(), 10),
-		instanceSegment(instance),
-		event.ID,
-		string(eventData),
-		string(payloadEventData),
-	).Err()
-}
-
-// Remove a scheduled future event. Not cluster-safe.
-// KEYS[1] - future event zset key
-// KEYS[2] - future event key
-// KEYS[3] - instance payload key
-var removeFutureEventCmd = redis.NewScript(`
-	redis.call("ZREM", KEYS[1], KEYS[2])
-	local eventID = redis.call("HGET", KEYS[2], "id")
-	redis.call("HDEL", KEYS[3], eventID)
-	return redis.call("DEL", KEYS[2])
-`)
-
-// removeFutureEvent removes a scheduled future event for the given event. Events are associated via their ScheduleEventID
-func removeFutureEventP(ctx context.Context, p redis.Pipeliner, instance *core.WorkflowInstance, event *history.Event) {
-	key := futureEventKey(instance, event.ScheduleEventID)
-	removeFutureEventCmd.Run(ctx, p, []string{futureEventsKey(), key, payloadKey(instance)})
-}
-
 // Find all due future events. For each event:
 // - Look up event data
 // - Add to pending event stream for workflow instance

backend/redis/redis.go

@@ -59,12 +59,10 @@ func NewRedisBackend(client redis.UniversalClient, opts ...RedisBackendOption) (
 	// them, loads them. This doesn't work when using (transactional) pipelines, so eagerly load them on startup.
 	ctx := context.Background()
 	cmds := map[string]*redis.StringCmd{
-		"addFutureEventCmd":    addFutureEventCmd.Load(ctx, rb.rdb),
-		"futureEventsCmd":      futureEventsCmd.Load(ctx, rb.rdb),
-		"removeFutureEventCmd": removeFutureEventCmd.Load(ctx, rb.rdb),
-		"deleteInstanceCmd":    deleteCmd.Load(ctx, rb.rdb),
-		"expireInstanceCmd":    expireCmd.Load(ctx, rb.rdb),
-		"addPayloadsCmd":       addPayloadsCmd.Load(ctx, rb.rdb),
+		"futureEventsCmd":   futureEventsCmd.Load(ctx, rb.rdb),
+		"deleteInstanceCmd": deleteCmd.Load(ctx, rb.rdb),
+		"expireInstanceCmd": expireCmd.Load(ctx, rb.rdb),
+		"addPayloadsCmd":    addPayloadsCmd.Load(ctx, rb.rdb),
 	}
 	for name, cmd := range cmds {
 		// fmt.Println(name, cmd.Val())