Fix more linter errors

Author: cschleiden

.golangci.yml

@@ -7,8 +7,6 @@ linters:
   enable:
     - bidichk
     - bodyclose
-    - errcheck
-    - errname
     - errorlint
     - goprintffuncname
     - govet
@@ -28,24 +26,34 @@ linters:
     - wastedassign
     - whitespace
     - unused
-    - goworkflows
+    # - goworkflows
+  disable:
+    - errname
+    - errcheck
+    - errorlint
   settings:
     staticcheck:
       checks:
         - "all"
+        - "-SA1019"
+        - "-ST1000"
         - "-ST1003"
-    custom:
-      goworkflows:
-        type: "module"
-        original-url: "github.com/cschleiden/go-workflows/analyzer"
-        settings:
-          checkprivatereturnvalues: true
+        - "-ST1005"
+        - "-ST1012"
+        - "-ST1020"
+        - "-SA5010"
+    # custom:
+    #   goworkflows:
+    #     type: "module"
+    #     original-url: "github.com/cschleiden/go-workflows/analyzer"
+    #     settings:
+    #       checkprivatereturnvalues: true
 
 
 formatters:
   enable:
     - gofmt
-    - goimports
+    # - goimports
   settings:
     goimports:
       local-prefixes:

backend/mysql/diagnostics.go

@@ -84,6 +84,10 @@ func (mb *mysqlBackend) GetWorkflowInstances(ctx context.Context, afterInstanceI
 		})
 	}
 
+	if rows.Err() != nil {
+		return nil, rows.Err()
+	}
+
 	return instances, nil
 }
 
@@ -128,7 +132,7 @@ func (mb *mysqlBackend) GetWorkflowInstance(ctx context.Context, instance *core.
 	}
 
 	return &diag.WorkflowInstanceRef{
-		Instance:    core.NewWorkflowInstance(id, executionID),
+		Instance:    instance,
 		CreatedAt:   createdAt,
 		CompletedAt: completedAt,
 		State:       state,