Skip to content

Commit f254389

Browse files
cschleidencschleiden
committed
UI errors when workflow has been created but not started executing
Fixes #321
1 parent 1f6bb05 commit f254389

File tree

8 files changed

+26
-18
lines changed

8 files changed

+26
-18
lines changed

‎diag/app/build/asset-manifest.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
{
22
"files": {
33
"main.css": "./static/css/main.8b0db0ad.css",
4-
"main.js": "./static/js/main.fbd9a17e.js",
4+
"main.js": "./static/js/main.e117a19e.js",
55
"index.html": "./index.html",
66
"main.8b0db0ad.css.map": "./static/css/main.8b0db0ad.css.map",
7-
"main.fbd9a17e.js.map": "./static/js/main.fbd9a17e.js.map"
7+
"main.e117a19e.js.map": "./static/js/main.e117a19e.js.map"
88
},
99
"entrypoints": [
1010
"static/css/main.8b0db0ad.css",
11-
"static/js/main.fbd9a17e.js"
11+
"static/js/main.e117a19e.js"
1212
]
1313
}

‎diag/app/build/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<!doctype html><html lang="en"><head><meta charset="utf-8"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><title>go-workflows</title><script defer="defer" src="./static/js/main.fbd9a17e.js"></script><link href="./static/css/main.8b0db0ad.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
1+
<!doctype html><html lang="en"><head><meta charset="utf-8"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><title>go-workflows</title><script defer="defer" src="./static/js/main.e117a19e.js"></script><link href="./static/css/main.8b0db0ad.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>

‎diag/app/build/static/js/main.fbd9a17e.js‎ renamed to ‎diag/app/build/static/js/main.e117a19e.js‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎diag/app/build/static/js/main.fbd9a17e.js.LICENSE.txt‎ renamed to ‎diag/app/build/static/js/main.e117a19e.js.LICENSE.txt‎

File renamed without changes.

‎diag/app/build/static/js/main.e117a19e.js.map‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎diag/app/build/static/js/main.fbd9a17e.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎diag/app/src/Instance.tsx‎

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,16 @@ function Instance() {
4747
);
4848
}
4949

50-
const startedEvent = instance.history.find(
50+
const startedEvent = instance.history?.find(
5151
(e) => e.type === "WorkflowExecutionStarted"
52-
) as HistoryEvent<ExecutionStartedAttributes>;
52+
) as HistoryEvent<ExecutionStartedAttributes> | undefined;
5353

54-
const workflowName = startedEvent.attributes.name;
55-
const inputs = startedEvent.attributes.inputs;
54+
const workflowName = startedEvent?.attributes.name;
55+
const inputs = startedEvent?.attributes.inputs;
5656

5757
let wfResult: string | undefined;
5858
let wfError: {} | undefined;
59-
const finishedEvent = instance.history.find(
59+
const finishedEvent = instance.history?.find(
6060
(e) =>
6161
e.type === "WorkflowExecutionFinished" ||
6262
e.type === "WorkflowExecutionContinuedAsNew"
@@ -70,7 +70,7 @@ function Instance() {
7070
<div>
7171
<div className="d-flex align-items-center">
7272
<h2>
73-
Workflow: <code>{workflowName}</code>
73+
Workflow: <code>{workflowName || <i>Pending</i>}</code>
7474
</h2>
7575
</div>
7676

@@ -146,10 +146,18 @@ function Instance() {
146146

147147
<h2 className="mt-3">History</h2>
148148
<Accordion alwaysOpen>
149-
{instance.history.map((event, idx) => (
150-
<Accordion.Item eventKey={`${idx}`} key={event.id}>
149+
{instance.history?.map((event, idx) => (
150+
<Accordion.Item
151+
eventKey={`${idx}`}
152+
key={event.id}
153+
className={
154+
event.schedule_event_id
155+
? `schedule-event-${event.schedule_event_id}`
156+
: ""
157+
}
158+
>
151159
<Accordion.Header>
152-
<h5 className="d-flex flex-grow-1 align-items-center pe-3">
160+
<h5 className={"d-flex flex-grow-1 align-items-center pe-3"}>
153161
<div className="text-secondary" style={{ width: "50px" }}>
154162
#{event.sequence_id}
155163
</div>

‎diag/app/src/client.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export interface WorkflowInstanceRef {
1515
}
1616

1717
export type WorkflowInstanceInfo = WorkflowInstanceRef & {
18-
history: HistoryEvent<any>[];
18+
history?: HistoryEvent<any>[];
1919
};
2020

2121
export interface HistoryEvent<TAttributes> {

0 commit comments

Comments
 (0)