Merge pull request #99 from cschleiden/schedule-ids

Set schedule event ids to 0 for workflow started events

Author: cschleiden

backend/test/e2e.go

@@ -36,6 +36,28 @@ func EndToEndBackendTest(t *testing.T, setup func() TestBackend, teardown func(b
 				require.Equal(t, "hello world", output)
 			},
 		},
+		{
+			name: "SimpleWorkflow_ExpectedHistory",
+			f: func(t *testing.T, ctx context.Context, c client.Client, w worker.Worker, b TestBackend) {
+				wf := func(ctx workflow.Context, msg string) (string, error) {
+					return msg + " world", nil
+				}
+				register(t, ctx, w, []interface{}{wf}, nil)
+
+				instance := runWorkflow(t, ctx, c, wf, "hello")
+
+				require.NoError(t, c.WaitForWorkflowInstance(ctx, instance, time.Second*10))
+
+				events, err := b.GetWorkflowInstanceHistory(ctx, instance, nil)
+				require.NoError(t, err)
+
+				require.Equal(t, history.EventType_WorkflowTaskStarted, events[0].Type)
+				require.Equal(t, history.EventType_WorkflowExecutionStarted, events[1].Type)
+				require.Equal(t, int64(0), events[1].ScheduleEventID)
+				require.Equal(t, history.EventType_WorkflowExecutionFinished, events[2].Type)
+				require.Equal(t, int64(0), events[2].ScheduleEventID)
+			},
+		},
 		{
 			name: "UnregisteredWorkflow_Errors",
 			f: func(t *testing.T, ctx context.Context, c client.Client, w worker.Worker, b TestBackend) {

internal/workflow/executor.go

@@ -489,7 +489,7 @@ func (e *executor) processCommands(ctx context.Context, t *task.Workflow) (bool,
 						Name:   a.Name,
 						Inputs: a.Inputs,
 					},
-					history.ScheduleEventID(c.ID),
+					history.ScheduleEventID(0),
 				),
 			})
 
@@ -564,7 +564,7 @@ func (e *executor) processCommands(ctx context.Context, t *task.Workflow) (bool,
 					Result: a.Result,
 					Error:  a.Error,
 				},
-				history.ScheduleEventID(c.ID),
+				history.ScheduleEventID(0),
 			))
 
 			if instance.SubWorkflow() {