Merge pull request #252 from vroldanbet/do-not-silently-ignore-activity-poll-errors

cschleiden · web-flow · commit fd3024eab86b · 2023-09-25T21:10:23.000-07:00
do not silently ignore errors in ActivityWorker.poll
diff --git a/internal/worker/activity.go b/internal/worker/activity.go
@@ -201,6 +201,8 @@ func (aw *ActivityWorker) poll(ctx context.Context, timeout time.Duration) (*bac
 		if errors.Is(err, context.DeadlineExceeded) {
 			return nil, nil
 		}
+
+		return nil, err
 	}
 
 	return task, nil

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,8 @@ func (aw ActivityWorker) poll(ctx context.Context, timeout time.Duration) (bac`
`201`	`201`	`if errors.Is(err, context.DeadlineExceeded) {`
`202`	`202`	`return nil, nil`
`203`	`203`	`}`
	`204`	`+`
	`205`	`+ return nil, err`
`204`	`206`	`}`
`205`	`207`
`206`	`208`	`return task, nil`