Move Timer to internal package

Author: cschleiden

metrics/timer.go renamed to internal/metrics/timer.go

@@ -2,17 +2,19 @@ package metrics
 
 import (
 	"time"
+
+	"github.com/cschleiden/go-workflows/metrics"
 )
 
-type timer struct {
-	client Client
+type Timer struct {
+	client metrics.Client
 	start  time.Time
 	name   string
-	tags   Tags
+	tags   metrics.Tags
 }
 
-func Timer(client Client, name string, tags Tags) *timer {
-	return &timer{
+func NewTimer(client metrics.Client, name string, tags metrics.Tags) *Timer {
+	return &Timer{
 		client: client,
 		start:  time.Now(),
 		name:   name,
@@ -21,7 +23,7 @@ func Timer(client Client, name string, tags Tags) *timer {
 }
 
 // Stop the timer and send the elapsed time as milliseconds as a distribution metric
-func (t *timer) Stop() {
+func (t *Timer) Stop() {
 	elapsed := time.Since(t.start)
 	t.client.Distribution(t.name, t.tags, float64(elapsed/time.Millisecond))
 }

internal/worker/activity.go

@@ -13,6 +13,7 @@ import (
 	"github.com/cschleiden/go-workflows/backend/payload"
 	"github.com/cschleiden/go-workflows/internal/activity"
 	"github.com/cschleiden/go-workflows/internal/metrickeys"
+	mi "github.com/cschleiden/go-workflows/internal/metrics"
 	"github.com/cschleiden/go-workflows/internal/workflow"
 	"github.com/cschleiden/go-workflows/internal/workflowerrors"
 	"github.com/cschleiden/go-workflows/metrics"
@@ -153,7 +154,7 @@ func (aw *ActivityWorker) handleTask(ctx context.Context, task *backend.Activity
 		}(heartbeatCtx)
 	}
 
-	timer := metrics.Timer(ametrics, metrickeys.ActivityTaskProcessed, metrics.Tags{})
+	timer := mi.NewTimer(ametrics, metrickeys.ActivityTaskProcessed, metrics.Tags{})
 	defer timer.Stop()
 
 	result, err := aw.activityTaskExecutor.ExecuteActivity(ctx, task)

internal/worker/workflow.go

@@ -13,6 +13,7 @@ import (
 	"github.com/cschleiden/go-workflows/backend/history"
 	"github.com/cschleiden/go-workflows/core"
 	"github.com/cschleiden/go-workflows/internal/metrickeys"
+	mi "github.com/cschleiden/go-workflows/internal/metrics"
 	"github.com/cschleiden/go-workflows/internal/workflow"
 	"github.com/cschleiden/go-workflows/internal/workflow/cache"
 	"github.com/cschleiden/go-workflows/metrics"
@@ -150,7 +151,7 @@ func (ww *WorkflowWorker) handle(ctx context.Context, t *backend.WorkflowTask) {
 		metrickeys.EventName: eventName,
 	}, float64(timeInQueue/time.Millisecond))
 
-	timer := metrics.Timer(ww.backend.Metrics(), metrickeys.WorkflowTaskProcessed, metrics.Tags{
+	timer := mi.NewTimer(ww.backend.Metrics(), metrickeys.WorkflowTaskProcessed, metrics.Tags{
 		metrickeys.EventName: eventName,
 	})