Add InstanceID filter to diag webUI #350
Closed
barrett370 wants to merge 4 commits intocschleiden:mainfrom
Closed
Conversation
Owner
|
Do I see that correctly, is that only client-side filtering of the current page? |
Author
yes, just filtering the results that are being displayed. I see that in a recent PR you have fixed pagination to fetch only the instances to be rendered from the database, so perhaps this approach isn't as useful as it only works on a page-by-page basis |
Owner
|
Closing this for now. I think the idea still makes sense, but would like to see this more as a search instead of page/page filtering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to add ability to filter displayed instances in the WebUI, useful if instance Ids follow a specific convention to limit view to workflows related to a specific resource