Fix issues found with clang-17

Author: cschreib

CMakeLists.txt

@@ -136,6 +136,7 @@ macro(lxgui_set_warning_level target)
         target_compile_options(${target} PRIVATE -Wno-missing-noreturn)
         target_compile_options(${target} PRIVATE -Wno-shadow-uncaptured-local)
         target_compile_options(${target} PRIVATE -Wno-undefined-func-template)
+        target_compile_options(${target} PRIVATE -Wno-unsafe-buffer-usage)
         target_compile_options(${target} PRIVATE -fno-limit-debug-info)
 
         if (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")

impl/gui/gl/src/gui_gl_renderer_png.cpp

@@ -34,7 +34,7 @@ renderer::create_material_png_(const std::string& file_name, material::filter fi
     if (!file.good() || png_sig_cmp(signature, 0, pngsigsize) != 0) {
         throw gui::exception(
             "gui::gl::manager", file_name + "' is not a valid PNG image: '" +
-                                    std::string(signature, signature + pngsigsize) + "'.");
+                                    std::string(std::begin(signature), std::end(signature)) + "'.");
     }
 
     png_structp read_struct = nullptr;
@@ -81,7 +81,7 @@ renderer::create_material_png_(const std::string& file_name, material::filter fi
         std::vector<png_bytep> rows(height);
 
         for (std::size_t i = 0; i < height; ++i)
-            rows[i] = reinterpret_cast<png_bytep>(data.data() + i * width);
+            rows[i] = reinterpret_cast<png_bytep>(&data[i * width]);
 
         png_read_image(read_struct, rows.data());
 

impl/input/sdl/src/input_sdl_source.cpp

@@ -320,6 +320,7 @@ void source::on_sdl_event(const SDL_Event& event) {
         }
         break;
     }
+    default: break;
     }
 }
 

include/lxgui/gui_region.hpp

@@ -857,7 +857,7 @@ const ObjectType* down_cast(const region* self) {
 template<typename ObjectType>
 const ObjectType& down_cast(const region& self) {
     const ObjectType* object = dynamic_cast<const ObjectType*>(self);
-    if (self && !object) {
+    if (!object) {
         if (self.is_region_type(ObjectType::class_name)) {
             throw gui::exception(
                 self.get_region_type(), "cannot use down_cast() to " +

include/lxgui/gui_vector2.hpp

@@ -66,7 +66,8 @@ struct vector2 {
 
     vector2 get_scaled(const vector2& v) const noexcept {
         vector2 vec = *this;
-        vec.scale(v);
+        vec.x *= v.x;
+        vec.y *= v.y;
         return vec;
     }