Added test for throwing in object constructor

Author: cschreib

tests/runtime_tests.cpp

@@ -417,6 +417,14 @@ TEST_CASE("make observable", "[make_observable_unique]") {
     REQUIRE(instances == 0);
 }
 
+TEST_CASE("make observable throw in constructor", "[make_observable_unique]") {
+    REQUIRE_THROWS_AS(
+        oup::make_observable_unique<test_object_thrower>(),
+        throw_constructor);
+
+    REQUIRE(instances_thrower == 0);
+}
+
 TEST_CASE("observer default constructor", "[observer_construction]") {
     {
         test_wptr ptr{};

tests/tests_common.hpp

@@ -1,5 +1,7 @@
 #include "oup/observable_unique_ptr.hpp"
 
+#include <exception>
+
 int instances = 0;
 int instances_derived = 0;
 int instances_thrower = 0;
@@ -21,9 +23,11 @@ struct test_object_derived : test_object {
     virtual ~test_object_derived() noexcept { --instances_derived; }
 };
 
+struct throw_constructor : std::exception {};
+
 struct test_object_thrower {
-    test_object_thrower() { throw std::exception{}; }
-    ~test_object_thrower() noexcept { --instances_thrower; }
+    test_object_thrower() { throw throw_constructor{}; }
+    ~test_object_thrower() { --instances_thrower; }
 
     test_object_thrower(const test_object_thrower&) = delete;
     test_object_thrower(test_object_thrower&&) = delete;
@@ -53,7 +57,9 @@ struct test_deleter {
         return *this;
     }
 
-    void operator() (test_object* ptr) { delete ptr; }
+    void operator() (test_object* ptr) noexcept { delete ptr; }
+    void operator() (test_object_thrower* ptr) noexcept { delete ptr; }
+    void operator() (std::nullptr_t) noexcept {}
 };
 
 using test_ptr = oup::observable_unique_ptr<test_object>;