[Fixes GeoNode#7603] RemoteServices legend urls do not contain 'sld_service' param (GeoNode#7604)

* [Fixes GeoNode#7603] RemoteServices legend urls do not contain 'sld_service' param

* - Test fix

Author: Alessio Fabiani

geonode/services/serviceprocessors/wms.py

@@ -41,12 +41,15 @@
 from django.template.defaultfilters import slugify
 from django.utils.translation import ugettext as _
 
-from geonode.base.models import Link, TopicCategory
+from geonode.base.models import (
+    Link,
+    ResourceBase,
+    TopicCategory)
 from geonode.layers.models import Layer
 from geonode.layers.utils import resolve_regions
 from geonode.thumbs.thumbnails import create_thumbnail
 from geonode.geoserver.helpers import set_attributes_from_geoserver
-from geonode.utils import http_client
+from geonode.utils import http_client, get_legend_url
 from geonode.base.bbox_utils import BBOXHelper
 
 from owslib.map import wms111, wms130
@@ -322,34 +325,32 @@ def _create_layer_legend_link(self, geonode_layer):
         creating the legend by making a request directly to the original
         service.
         """
+        cleaned_url, service, version, request = WmsServiceHandler.get_cleaned_url_params(self.url)
         _p_url = urlparse(self.url)
-        _q_separator = "&" if _p_url.query else "?"
-        params = {
-            "service": "WMS",
-            "version": self.parsed_service.version,
-            "request": "GetLegendGraphic",
-            "format": "image/png",
-            "width": 20,
-            "height": 20,
-            "layer": geonode_layer.name,
-            "legend_options": (
-                "fontAntiAliasing:true;fontSize:12;forceLabels:on")
-        }
-        kvp = "&".join("{}={}".format(*item) for item in params.items())
-        legend_url = f"{geonode_layer.remote_service.service_url}{_q_separator}{kvp}"
-        logger.debug(f"legend_url: {legend_url}")
-        Link.objects.get_or_create(
-            resource=geonode_layer.resourcebase_ptr,
-            url=legend_url,
-            name='Legend',
-            defaults={
-                "extension": 'png',
-                "name": 'Legend',
-                "url": legend_url,
-                "mime": 'image/png',
-                "link_type": 'image',
-            }
+        legend_url = get_legend_url(
+            geonode_layer, "",
+            service_url=f"{_p_url.scheme}://{_p_url.netloc}{_p_url.path}",
+            layer_name=geonode_layer.name,
+            version=version,
+            params=_p_url.query
         )
+        logger.debug(f"legend_url: {legend_url}")
+        try:
+            Link.objects.get_or_create(
+                resource=geonode_layer.resourcebase_ptr,
+                url=legend_url,
+                name='Legend',
+                defaults={
+                    "extension": 'png',
+                    "name": 'Legend',
+                    "url": legend_url,
+                    "mime": 'image/png',
+                    "link_type": 'image',
+                }
+            )
+        except ResourceBase.DoesNotExist as e:
+            logger.exception(e)
+        return legend_url
 
     def _create_layer_service_link(self, geonode_layer):
         ogc_wms_url = geonode_layer.ows_url

geonode/services/tests.py

@@ -681,6 +681,8 @@ def test_get_resources(self, mock_wms):
             Layer.objects.filter(remote_service=geonode_service).delete()
             self.assertEqual(HarvestJob.objects.filter(service=geonode_service,
                                                        resource_id=geonode_layer.alternate).count(), 0)
+            legend_url = handler._create_layer_legend_link(geonode_layer)
+            self.assertTrue('sld_version=1.1.0' in str(legend_url))
         except Service.DoesNotExist as e:
             # In the case the Service URL becomes inaccessible for some reason
             logger.error(e)

geonode/utils.py

@@ -1615,14 +1615,24 @@ def slugify_zh(text, separator='_'):
     return text
 
 
-def get_legend_url(instance, style_name):
+def get_legend_url(
+        instance, style_name, /,
+        service_url=None,
+        layer_name=None,
+        version='1.3.0',
+        sld_version='1.1.0',
+        width=20,
+        height=20,
+        params=None):
     from geonode.geoserver.helpers import ogc_server_settings
 
-    return(f"{ogc_server_settings.PUBLIC_LOCATION}ows?"
-           "service=WMS&request=GetLegendGraphic&format=image/png&WIDTH=20&HEIGHT=20&"
-           f"LAYER={instance.alternate}&STYLE={style_name}&version=1.3.0&"
-           "sld_version=1.1.0&legend_options=fontAntiAliasing:true;fontSize:12;forceLabels:on"
-        )
+    _service_url = service_url or f"{ogc_server_settings.PUBLIC_LOCATION}ows"
+    _layer_name = layer_name or instance.alternate
+    _params = f"&{params}" if params else ""
+    return(f"{_service_url}?"
+           f"service=WMS&request=GetLegendGraphic&format=image/png&WIDTH={width}&HEIGHT={height}&"
+           f"LAYER={_layer_name}&STYLE={style_name}&version={version}&"
+           f"sld_version={sld_version}&legend_options=fontAntiAliasing:true;fontSize:12;forceLabels:on{_params}")
 
 
 def set_resource_default_links(instance, layer, prune=False, **kwargs):
@@ -1847,24 +1857,31 @@ def set_resource_default_links(instance, layer, prune=False, **kwargs):
         # Legend link
         logger.debug(" -- Resource Links[Legend link]...")
         try:
-            for style in set(list(instance.styles.all()) + [instance.default_style, ]):
-                if style:
-                    style_name = os.path.basename(
-                        urlparse(style.sld_url).path).split('.')[0]
-                    legend_url = get_legend_url(instance, style_name)
-
-                    if Link.objects.filter(resource=instance.resourcebase_ptr, url=legend_url).count() < 2:
-                        Link.objects.update_or_create(
-                            resource=instance.resourcebase_ptr,
-                            name='Legend',
-                            url=legend_url,
-                            defaults=dict(
-                                extension='png',
+            if instance.storeType != 'remoteStore':
+                for style in set(list(instance.styles.all()) + [instance.default_style, ]):
+                    if style:
+                        style_name = os.path.basename(
+                            urlparse(style.sld_url).path).split('.')[0]
+                        legend_url = get_legend_url(instance, style_name)
+                        if Link.objects.filter(resource=instance.resourcebase_ptr, url=legend_url).count() < 2:
+                            Link.objects.update_or_create(
+                                resource=instance.resourcebase_ptr,
+                                name='Legend',
                                 url=legend_url,
-                                mime='image/png',
-                                link_type='image',
+                                defaults=dict(
+                                    extension='png',
+                                    url=legend_url,
+                                    mime='image/png',
+                                    link_type='image',
+                                )
                             )
-                        )
+            else:
+                from geonode.services.serviceprocessors.handler import get_service_handler
+                handler = get_service_handler(
+                    instance.remote_service.base_url, service_type=instance.remote_service.type)
+                if hasattr(handler, '_create_layer_legend_link'):
+                    handler._create_layer_legend_link(instance)
+
             logger.debug(" -- Resource Links[Legend link]...done!")
         except Exception as e:
             logger.debug(f" -- Resource Links[Legend link]...error: {e}")