- Remove new keyword from Socks4aProxyClient

- AppVeyor: nuget package publishing on GitHub Releases
- Disable MSBuild warning 1573 (undocumented parameter)

Author: grandsilence

Leaf.xNet/Leaf.xNet.csproj

@@ -48,7 +48,7 @@
     <Copyright>© 2018-2020 Developed by Grand Silence — Kelog Studio</Copyright>
     <PackageTags>net,http,socks,proxy,cloudflare,xnet,https,stormwall,useragent,parsing,bot,web,crowling</PackageTags>
     <PackageIcon>icon.png</PackageIcon>
-    <NoWarn>1591</NoWarn>
+    <NoWarn>1591,1573</NoWarn>
     <Description>Improved xNet for .NET Framework 4.5.2+ &amp; .NET Core 2+</Description> <!-- Ignore warinings abound undocumented code -->
   </PropertyGroup>
 

Leaf.xNet/Services/Cloudflare/ChallengeSolver.cs

@@ -25,6 +25,7 @@ public static class ChallengeSolver
         /// </summary>
         /// <param name="challengePageContent">The HTML content of the clearance page, which contains the challenge.</param>
         /// <param name="targetHost">The hostname of the protected website.</param>
+        /// <param name="targetPort">The port of the protected website.</param>
         /// <returns>The solution.</returns>
         public static ChallengeSolution Solve(string challengePageContent, string targetHost, int targetPort)
         {

Leaf.xNet/~Proxy/Socks4aProxyClient.cs

@@ -83,7 +83,7 @@ public static bool TryParse(string proxyAddress, out Socks4AProxyClient result)
 
 
         // ReSharper disable once UnusedMember.Global
-        internal new void SendCommand(NetworkStream nStream, byte command, string destinationHost, int destinationPort)
+        internal void SendCommand(NetworkStream nStream, byte command, string destinationHost, int destinationPort)
         {
             var dstPort = GetPortBytes(destinationPort);
             byte[] dstIp = { 0, 0, 0, 1 };

appveyor.yml

@@ -28,6 +28,8 @@ build:
   publish_nuget: true
   verbosity: minimal
 artifacts:
+- path: Leaf.xNet\bin\Release\Leaf.xNet.$(appveyor_build_version).nupkg
+  name: Leaf.xNet_v$(appveyor_build_version)__Nuget_All_Targets
 - path: Leaf.xNet\bin\Release\net452
   name: Leaf.xNet_v$(appveyor_build_version)__NET_Framework_4.5.2
 - path: Leaf.xNet\bin\Release\net462
@@ -50,7 +52,7 @@ deploy:
   release: Leaf.xNet v$(appveyor_build_version)
   auth_token:
     secure: NQtMOO3yB309cDK/pFWRiQ==
-  artifact: Leaf.xNet_v$(appveyor_build_version)__NET_Framework_4.5.2;Leaf.xNet_v$(appveyor_build_version)__NET_Framework_4.6.2;Leaf.xNet_v$(appveyor_build_version)__NET_Framework_4.7.2;Leaf.xNet_v$(appveyor_build_version)__NET_Framework_4.8;Leaf.xNet_v$(appveyor_build_version)__NET_Standard_2.0
+  artifact: Leaf.xNet_v$(appveyor_build_version)__Nuget_All_Targets;Leaf.xNet_v$(appveyor_build_version)__NET_Framework_4.5.2;Leaf.xNet_v$(appveyor_build_version)__NET_Framework_4.6.2;Leaf.xNet_v$(appveyor_build_version)__NET_Framework_4.7.2;Leaf.xNet_v$(appveyor_build_version)__NET_Framework_4.8;Leaf.xNet_v$(appveyor_build_version)__NET_Standard_2.0
   on:
     branch: master
 only_commits: