Skip to content

Commit 0cf426e

Browse files
committed
feat: remove unused domain and certificate parameters from Azure configuration
1 parent bca0dab commit 0cf426e

File tree

3 files changed

+1
-18
lines changed

3 files changed

+1
-18
lines changed

.github/workflows/azure-dev.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@ jobs:
2525
AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}
2626
AZURE_ENV_NAME: ${{ vars.AZURE_ENV_NAME }}
2727
AZURE_LOCATION: ${{ vars.AZURE_LOCATION }}
28-
AZURE_DOMAINAPEX: "copilotthatjawn.com"
29-
AZURE_DOMAINWWW: "www.copilotthatjawn.com"
30-
AZURE_CERTIFICATENAME: "copilotthatjawn.com-cae-uanp-250608192822"
31-
AZURE_WWWCERTIFICATENAME: "www.copilotthatjawn.com-cae-uanp-250608193349"
3228

3329
steps:
3430
- name: Checkout

AppHost/AppHost.cs

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@
55

66
var builder = DistributedApplication.CreateBuilder(args);
77

8-
var apexDomain = builder.AddParameter("domainApex");
9-
var wwwDomain = builder.AddParameter("domainWww");
10-
var certName = builder.AddParameter("certificateName");
11-
var wwwCertName = builder.AddParameter("wwwCertificateName");
12-
138
// NOTE: The type returned by AddAzureStorage is IResourceBuilder<AzureStorageResource>,
149
// but if storage is being cast or wrapped, ensure it is of the correct type for extension methods.
1510
var storage = builder.AddAzureStorage("azure-storage")
@@ -27,13 +22,6 @@
2722
var web = builder.AddProject<Web>("web")
2823
.WithReference(tables)
2924
.WaitFor(tables)
30-
.WithExternalHttpEndpoints()
31-
.PublishAsAzureContainerApp((mod,app) =>
32-
{
33-
#pragma warning disable ASPIREACADOMAINS001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
34-
app.ConfigureCustomDomain(apexDomain, certName);
35-
app.ConfigureCustomDomain(wwwDomain, wwwCertName);
36-
#pragma warning restore ASPIREACADOMAINS001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
37-
});
25+
.WithExternalHttpEndpoints();
3826

3927
builder.Build().Run();

AppHost/infra/web/web.tmpl.bicepparam

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
using './web.module.bicep'
22

33
param azure_storage_outputs_tableendpoint = '{{ .Env.AZURE_STORAGE_TABLEENDPOINT }}'
4-
param outputs_azure_container_apps_environment_default_domain = '{{ .Env.AZURE_CONTAINER_APPS_ENVIRONMENT_DEFAULT_DOMAIN }}'
54
param outputs_azure_container_apps_environment_id = '{{ .Env.AZURE_CONTAINER_APPS_ENVIRONMENT_ID }}'
65
param outputs_azure_container_registry_endpoint = '{{ .Env.AZURE_CONTAINER_REGISTRY_ENDPOINT }}'
76
param outputs_azure_container_registry_managed_identity_id = '{{ .Env.AZURE_CONTAINER_REGISTRY_MANAGED_IDENTITY_ID }}'

0 commit comments

Comments
 (0)