Fixed AttentionCommand to properly connect and stay connected

Author: csharpfritz

Fritz.Chatbot/Commands/AttentionCommand.cs

@@ -5,19 +5,28 @@
 using Microsoft.AspNetCore.SignalR.Client;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Logging;
 
 namespace Fritz.Chatbot.Commands
 {
-	public class AttentionCommand : IBasicCommand
+	public class AttentionCommand : IBasicCommand, IDisposable
 	{
 		private readonly IConfiguration Configuration;
 
-		public AttentionCommand(IConfiguration configuration)
+		public ILogger Logger { get; }
+
+		public AttentionCommand(IConfiguration configuration, ILoggerFactory loggerFactory)
 		{
 			this.Configuration = configuration;
+			this.Logger = loggerFactory.CreateLogger("AttentionCommand");
+
 			var thisUri = new Uri(configuration["FritzBot:ServerUrl"], UriKind.Absolute);
-			this.Client = new HubConnectionBuilder().WithUrl(new Uri(thisUri, "attentionhub").ToString()).Build();
-			this.Client.StartAsync();
+			var attentionUri = new Uri(thisUri, "attentionhub");
+
+			Logger.LogTrace($"Connecting AttentionCommand to: {attentionUri}");
+
+			this.Client = new HubConnectionBuilder().WithUrl(attentionUri.ToString()).Build();
+
 		}
 
 		protected HubConnection Client { get; }
@@ -30,11 +39,19 @@ public AttentionCommand(IConfiguration configuration)
 
 		public async Task Execute(IChatService chatService, string userName, ReadOnlyMemory<char> rhs)
 		{
+
+			await this.Client.StartAsync();
+
 			await this.Client.InvokeAsync("AlertFritz");
 
 			var attentionText = Configuration["FritzBot:AttentionCommand:TemplateText"];
 
 			await chatService.SendMessageAsync(string.Format(attentionText, userName));
 		}
+
+		public void Dispose()
+		{
+			Client.DisposeAsync();
+		}
 	}
 }

Fritz.StreamTools/appsettings.json

@@ -76,7 +76,7 @@
 		"RepositoryOwner": "csharpfritz",
 		"ExcludeUsers": [
 			"csharpfritz",
-			"dependabot"
+			"dependabot[bot]"
 		]
 	}
 }

Test/Startup/ConfigureServicesTests.cs

@@ -57,8 +57,10 @@ private static Dictionary<string, string> MakeFakeConfiguration(string twitchCli
 			{
 				{"StreamServices:Twitch:ClientId", twitchClientId},
 				{"StreamServices:Mixer:Channel", mixerClientId},
-				{"StreamServices:Fake:Enabled", enableFake.ToString()}
+				{"StreamServices:Fake:Enabled", enableFake.ToString()},
+				{"FritzBot:ServerUrl", "http://localhost:80" }
 			};
 		}
+
 	}
 }