another attempt to reresolve linter issues #4

Signed-off-by: Ariel Kass <[email protected]>

Author: Ariel Kass

controllers/pvc_test.go

@@ -80,14 +80,17 @@ var mockPersistentVolumeClaim = &corev1.PersistentVolumeClaim{
 
 func createFakeScheme(t *testing.T) *runtime.Scheme {
 	t.Helper()
+
 	scheme, err := replicationv1alpha1.SchemeBuilder.Build()
 	if err != nil {
 		require.Fail(t, "unable to build scheme")
 	}
+
 	err = corev1.AddToScheme(scheme)
 	if err != nil {
 		require.Fail(t, "failed to add corev1 scheme")
 	}
+
 	err = replicationv1alpha1.AddToScheme(scheme)
 	if err != nil {
 		require.Fail(t, "failed to add replicationv1alpha1 scheme")
@@ -98,6 +101,7 @@ func createFakeScheme(t *testing.T) *runtime.Scheme {
 
 func createFakeVolumeReplicationReconciler(t *testing.T, obj ...runtime.Object) VolumeReplicationReconciler {
 	t.Helper()
+
 	scheme := createFakeScheme(t)
 	client := fake.NewClientBuilder().WithScheme(scheme).WithRuntimeObjects(obj...).Build()
 

controllers/volumereplication_controller.go

@@ -116,6 +116,7 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 	if err != nil {
 		logger.Error(err, "failed to validate parameters of volumeReplicationClass", "VRCName", instance.Spec.VolumeReplicationClass)
 		setFailureCondition(instance)
+
 		uErr := r.updateReplicationStatus(ctx, instance, logger, getCurrentReplicationState(instance), err.Error())
 		if uErr != nil {
 			logger.Error(uErr, "failed to update volumeReplication status", "VRName", instance.Name)
@@ -179,6 +180,7 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 		if vgErr != nil {
 			logger.Error(vgErr, "failed to get VG", "VGName", instance.Spec.DataSource.Name)
 			setFailureCondition(instance)
+
 			uErr := r.updateReplicationStatus(ctx, instance, logger, getCurrentReplicationState(instance), vgErr.Error())
 			if uErr != nil {
 				logger.Error(uErr, "failed to update volumeReplication status", "VRName", instance.Name)
@@ -192,6 +194,7 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 		err = fmt.Errorf("unsupported datasource kind")
 		logger.Error(err, "given kind not supported", "Kind", instance.Spec.DataSource.Kind)
 		setFailureCondition(instance)
+
 		uErr := r.updateReplicationStatus(ctx, instance, logger, getCurrentReplicationState(instance), err.Error())
 		if uErr != nil {
 			logger.Error(uErr, "failed to update volumeReplication status", "VRName", instance.Name)

main.go

@@ -63,7 +63,9 @@ func init() {
 
 func main() {
 	var metricsAddr string
+
 	var leaderElectionNamespace string
+
 	var probeAddr string
 
 	var enableLeaderElection bool