resolving lint issues - gocritic (skip), godot, funcorder

Signed-off-by: Ariel Kass <[email protected]>

Author: Ariel Kass

controllers/pvc.go

@@ -27,6 +27,7 @@ import (
 )
 
 // getPVCDataSource get pvc, pv object from the request.
+//nolint:gocritic
 func (r VolumeReplicationReconciler) getPVCDataSource(ctx context.Context, logger logr.Logger, req types.NamespacedName) (*corev1.PersistentVolumeClaim, *corev1.PersistentVolume, error) {
 	pvc := &corev1.PersistentVolumeClaim{}
 	err := r.Client.Get(ctx, req, pvc)

controllers/vg.go

@@ -26,6 +26,7 @@ import (
 )
 
 // getVGDataSource get vg content, vg object from the request.
+//nolint:gocritic
 func (r VolumeReplicationReconciler) getVGDataSource(ctx context.Context, logger logr.Logger, req types.NamespacedName) (*volumegroupv1.VolumeGroup, *volumegroupv1.VolumeGroupContent, error) {
 	vg := &volumegroupv1.VolumeGroup{}
 	err := r.Client.Get(ctx, req, vg)

controllers/volumereplication_controller.go

@@ -388,24 +388,6 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 	return ctrl.Result{}, nil
 }
 
-func (r *VolumeReplicationReconciler) updateReplicationStatus(
-	ctx context.Context,
-	instance *replicationv1alpha1.VolumeReplication,
-	logger logr.Logger,
-	state replicationv1alpha1.State,
-	message string) error {
-	instance.Status.State = state
-	instance.Status.Message = message
-	instance.Status.ObservedGeneration = instance.Generation
-	if err := r.Client.Status().Update(ctx, instance); err != nil {
-		logger.Error(err, "failed to update status")
-
-		return err
-	}
-
-	return nil
-}
-
 // SetupWithManager sets up the controller with the Manager.
 func (r *VolumeReplicationReconciler) SetupWithManager(mgr ctrl.Manager, cfg *config.DriverConfig) error {
 	err := r.waitForCrds()
@@ -445,6 +427,24 @@ func (r *VolumeReplicationReconciler) SetupWithManager(mgr ctrl.Manager, cfg *co
 		WithEventFilter(pred).Complete(r)
 }
 
+func (r *VolumeReplicationReconciler) updateReplicationStatus(
+	ctx context.Context,
+	instance *replicationv1alpha1.VolumeReplication,
+	logger logr.Logger,
+	state replicationv1alpha1.State,
+	message string) error {
+	instance.Status.State = state
+	instance.Status.Message = message
+	instance.Status.ObservedGeneration = instance.Generation
+	if err := r.Client.Status().Update(ctx, instance); err != nil {
+		logger.Error(err, "failed to update status")
+
+		return err
+	}
+
+	return nil
+}
+
 func (r *VolumeReplicationReconciler) waitForCrds() error {
 	logger := r.Log.WithName("checkingDependencies")
 
@@ -665,8 +665,8 @@ func (r *VolumeReplicationReconciler) enableReplication(logger logr.Logger, repl
 
 // getVolumeContentSource is a helper function to process provisioning requests that include a DataSource
 // currently we provide Snapshot and PVC, the default case allows the provisioner to still create a volume
-// so that an external controller can act upon it.   Additional DataSource types can be added here with
-// an appropriate implementation function
+// so that an external controller can act upon it. Additional DataSource types can be added here with
+// an appropriate implementation function.
 func (r *VolumeReplicationReconciler) getReplicationSource(logger logr.Logger, kind string, volumeHandle string) (*replicationlib.ReplicationSource, error) {
 	switch kind {
 	case pvcDataSource:

controllers/volumereplicationclass.go

@@ -27,6 +27,7 @@ import (
 )
 
 // getVolumeReplicationClass get volume replication class object from the subjected namespace and return the same.
+//nolint:gocritic
 func (r VolumeReplicationReconciler) getVolumeReplicationClass(ctx context.Context, logger logr.Logger, vrcName string) (*replicationv1alpha1.VolumeReplicationClass, error) {
 	vrcObj := &replicationv1alpha1.VolumeReplicationClass{}
 	err := r.Client.Get(ctx, types.NamespacedName{Name: vrcName}, vrcObj)