resolve wsl_v5 linter issues

Signed-off-by: Ariel Kass <[email protected]>

Author: Ariel Kass

controllers/parameters.go

@@ -37,6 +37,7 @@ const (
 // replicationclass which are matching the prefix.
 func filterPrefixedParameters(prefix string, param map[string]string) map[string]string {
 	newParam := map[string]string{}
+
 	for key, val := range param {
 		if !strings.HasPrefix(key, prefix) {
 			newParam[key] = val
@@ -62,7 +63,6 @@ func validatePrefixedParameters(param map[string]string) error {
 				}
 			// keep adding known prefixes to this list.
 			default:
-
 				return fmt.Errorf("found unknown parameter key %q with reserved prefix %s", key, replicationParameterPrefix)
 			}
 		}

controllers/secret.go

@@ -36,6 +36,7 @@ func (r *VolumeReplicationReconciler) getSecret(ctx context.Context, logger logr
 
 			return nil, err
 		}
+
 		logger.Error(err, "error getting secret", "Secret Name", name, "Secret Namespace", namespace)
 
 		return nil, err

controllers/strings.go

@@ -33,6 +33,7 @@ func remove(slice []string, s string) (result []string) {
 		if item == s {
 			continue
 		}
+
 		result = append(result, item)
 	}
 

controllers/volumereplication_controller.go

@@ -216,13 +216,15 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 
 			return reconcile.Result{}, err
 		}
+
 		if pvc != nil {
 			if err = r.addFinalizerToPVC(ctx, logger, pvc); err != nil {
 				logger.Error(err, "Failed to add PersistentVolumeClaim finalizer")
 
 				return reconcile.Result{}, err
 			}
 		}
+
 		if vg != nil {
 			if err = r.addFinalizerToVG(ctx, logger, vg); err != nil {
 				logger.Error(err, "Failed to add VolumeGroup finalizer")
@@ -238,6 +240,7 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 
 				return ctrl.Result{}, err
 			}
+
 			if pvc != nil {
 				if err = r.removeFinalizerFromPVC(ctx, logger, pvc); err != nil {
 					logger.Error(err, "Failed to remove PersistentVolumeClaim finalizer")
@@ -260,6 +263,7 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 				return reconcile.Result{}, err
 			}
 		}
+
 		logger.Info("volumeReplication object is terminated, skipping reconciliation")
 
 		return ctrl.Result{}, nil
@@ -276,6 +280,7 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 	if err = r.enableReplication(logger, replicationSource, replicationHandle, parameters, secret); err != nil {
 		logger.Error(err, "failed to enable replication")
 		setFailureCondition(instance)
+
 		msg := replication.GetMessageFromError(err)
 		uErr := r.updateReplicationStatus(ctx, instance, logger, getCurrentReplicationState(instance), msg)
 		if uErr != nil {
@@ -339,6 +344,7 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 	if replicationErr != nil {
 		msg := replication.GetMessageFromError(replicationErr)
 		logger.Error(replicationErr, "failed to Replicate", "ReplicationState", instance.Spec.ReplicationState)
+
 		err = r.updateReplicationStatus(ctx, instance, logger, getCurrentReplicationState(instance), msg)
 		if err != nil {
 			logger.Error(err, "failed to update volumeReplication status", "VRName", instance.Name)
@@ -380,6 +386,7 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 	}
 
 	instance.Status.LastCompletionTime = getCurrentTime()
+
 	err = r.updateReplicationStatus(ctx, instance, logger, getReplicationState(instance), msg)
 	if err != nil {
 		return ctrl.Result{}, err
@@ -475,6 +482,7 @@ func (r *VolumeReplicationReconciler) waitForVolumeReplicationResource(logger lo
 		Kind:    resourceName,
 		Version: replicationv1alpha1.GroupVersion.Version,
 	})
+
 	for {
 		err := r.Client.List(context.TODO(), unstructuredResource)
 		if err == nil {
@@ -636,6 +644,7 @@ func (r *VolumeReplicationReconciler) disableVolumeReplication(logger logr.Logge
 
 			return nil
 		}
+
 		logger.Error(resp.Error, "failed to disable volume replication")
 
 		return resp.Error

main.go

@@ -63,9 +63,13 @@ func init() {
 
 func main() {
 	var metricsAddr string
+
 	var leaderElectionNamespace string
+	
 	var enableLeaderElection bool
+	
 	var probeAddr string
+	
 	var opts zap.Options
 
 	if strings.EqualFold(os.Getenv("DEVELOPMENT_MODE"), "true") {
@@ -162,6 +166,7 @@ func main() {
 	}
 
 	setupLog.Info("starting manager")
+
 	err = mgr.Start(ctrl.SetupSignalHandler())
 	if err != nil {
 		setupLog.Error(err, "problem running manager")

pkg/client/replication-client.go

@@ -122,6 +122,7 @@ func (rc *replicationClient) DemoteVolume(replicationSource *replicationlib.Repl
 		Parameters:        parameters,
 		Secrets:           secrets,
 	}
+
 	createCtx, cancel := context.WithTimeout(context.Background(), rc.timeout)
 	defer cancel()
 	resp, err := rc.client.DemoteVolume(createCtx, req)