Merge pull request #143 from csiro-coasts/task/140-consolidate-depth-coordinates

Consolidate depth coordinate methods

Author: mx-moth

docs/releases/development.rst

@@ -33,3 +33,4 @@ Next release (in development)
 * Add :func:`emsarray.utils.name_to_data_array()` and :func:`~emsarray.utils.data_array_to_name()` functions.
   Allow more functions to interchangeably take either a data array or the name of a data array
   (:pr:`142`).
+* Add :attr:`.Convention.depth_coordinates` and :meth:`.Convention.get_depth_coordinate_for_data_array()`. Deprecate functions :meth:`.Convention.get_depth_name()`, :meth:`.Convention.get_all_depth_names()`, and :meth:`Convention.get_time_name()`. Remove deprecated functions ``Convention.get_depths()`` and ``Convention.get_times()`` (:pr:`143`).

src/emsarray/cli/commands/extract_points.py

@@ -6,6 +6,7 @@
 
 import emsarray
 from emsarray.cli import BaseCommand, CommandException
+from emsarray.exceptions import NoSuchCoordinateError
 from emsarray.operations import point_extraction
 from emsarray.utils import to_netcdf_with_fixes
 
@@ -79,8 +80,8 @@ def handle(self, options: argparse.Namespace) -> None:
                 f"{rows.head()}\n"
                 f"(total rows: {len(rows)})")
         try:
-            time_name = dataset.ems.get_time_name()
-        except KeyError:
+            time_name = dataset.ems.time_coordinate.name
+        except NoSuchCoordinateError:
             time_name = None
 
         to_netcdf_with_fixes(