feat: streamline user prompts and improve variable handling in setup scripts

Author: tanhongit

setup/packages/global-dev-setup.sh

@@ -124,7 +124,7 @@ add_user_to_developers "$CURRENT_USER"
 if [ "$FORCE_UPDATE" = true ]; then
     echo ""
     echo "Adding all existing users to developers group..."
-    while IFS=: read -r username _ uid _ _ home shell; do
+    while IFS=: read -r username _ uid _ _ home _; do
         # Skip if UID < 1000 (system users) or if home doesn't exist
         if [ "$uid" -ge 1000 ] && [ -d "$home" ]; then
             add_user_to_developers "$username"

setup/system/fix-mysql-frozen.sh

@@ -29,7 +29,11 @@ echo "  1) Remove MySQL/MariaDB and clean everything (recommended)"
 echo "  2) Just remove FROZEN file (risky, may cause data corruption)"
 echo "  3) Cancel"
 
-read -r -p "Enter choice [1-3]: " choice
+if [[ $ACCEPT_INSTALL =~ ^[Yy]$ ]]; then
+    choice=1
+else
+    read -r -p "Enter choice [1-3]: " choice
+fi
 
 case "$choice" in
     1)

setup/system/setup-zabbix-nginx.sh

@@ -76,7 +76,6 @@ if [ -z "$PHP_FPM_SOCK" ]; then
     echo "⚠️  PHP-FPM socket not found, will use default: /run/php/php8.3-fpm.sock"
     echo "⚠️  Make sure PHP-FPM is installed and running"
     PHP_FPM_SOCK="/run/php/php8.3-fpm.sock"
-    PHP_VERSION="8.3"
 fi
 
 echo "📌 PHP-FPM socket: $PHP_FPM_SOCK"
@@ -208,9 +207,7 @@ if [ "$USE_SSL" = true ]; then
     echo "⚠️  Make sure your domain $DOMAIN_NAME points to this server IP!"
     read -r -p "Press Enter to continue or Ctrl+C to cancel..."
 
-    certbot --nginx -d "$DOMAIN_NAME" --non-interactive --agree-tos --email "$EMAIL" --redirect
-
-    if [ $? -eq 0 ]; then
+    if certbot --nginx -d "$DOMAIN_NAME" --non-interactive --agree-tos --email "$EMAIL" --redirect; then
         echo "✓ SSL certificate obtained successfully"
         echo "✓ HTTPS redirect enabled"
     else

setup/system/zabbix.sh

@@ -135,9 +135,9 @@ install_zabbix_server() {
         echo "  2) Remove ${DB_TYPE} and install fresh MySQL 8.0"
         echo "  3) Cancel installation"
         if [[ $ACCEPT_INSTALL =~ ^[Yy]$ ]]; then
-            zabbix_choice="1"
+            db_choice="1"
         else
-            read -r -p "Enter choice [1-3]: " zabbix_choice
+            read -r -p "Enter choice [1-3]: " db_choice
         fi
 
         case "$db_choice" in