feat: add payload validation in WebhookService and refactor WebhookAction

Author: tanhongit

src/Actions/WebhookAction.php

@@ -26,34 +26,17 @@ public function __invoke(): JsonResponse
         /** @var array<string, mixed> $payload */
         $payload = json_decode($request->getContent(), true);
 
-        if (!isset($payload['action'])) {
-            return response()->json(
-                ['message' => __('github-project::github-project.error.event.action_not_found')],
-                400
-            );
+        $validationResponse = $this->webhookService->validatePayload($payload);
+        if ($validationResponse !== null) {
+            return $validationResponse;
         }
 
-        $nodeId = $payload['projects_v2_item']['content_node_id'] ?? null;
-        $fieldData = $payload['changes']['field_value'] ?? null;
-        $editor = $payload['sender']['login'] ?? 'Unknown';
-
-        if (!$nodeId || !$fieldData) {
-            return response()->json(
-                ['message' => __('github-project::github-project.error.event.missing_fields')],
-                400
-            );
-        }
-
-        $fieldName = $fieldData['field_name'] ?? 'Unknown Field';
-        $fromValue = $fieldData['from']['name'] ?? 'Unknown';
-        $toValue = $fieldData['to']['name'] ?? 'Unknown';
-
         $message = view(
             'github-project::md.comment',
-            compact('editor', 'fieldName', 'fromValue', 'toValue')
+            compact('payload')
         )->render();
 
-        $this->webhookService->commentOnNode((string) $nodeId, $message);
+        $this->webhookService->commentOnNode((string) $payload['projects_v2_item']['content_node_id'], $message);
 
         return response()->json(['message' => __('github-project::github-project.success.message')]);
     }

src/Services/WebhookService.php

@@ -3,6 +3,7 @@
 namespace CSlant\GitHubProject\Services;
 
 use Github\Client;
+use Illuminate\Http\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 
 class WebhookService
@@ -26,6 +27,33 @@ public function eventRequestApproved(Request $request): bool
         return $this->eventApproved((string) $event);
     }
 
+    /**
+     * @param  array<string, mixed>  $payload
+     *
+     * @return JsonResponse|null
+     */
+    public function validatePayload(array $payload): ?JsonResponse
+    {
+        if (!isset($payload['action'])) {
+            return response()->json(
+                ['message' => __('github-project::github-project.error.event.action_not_found')],
+                400
+            );
+        }
+
+        $nodeId = $payload['projects_v2_item']['content_node_id'] ?? null;
+        $fieldData = $payload['changes']['field_value'] ?? null;
+
+        if (!$nodeId || !$fieldData) {
+            return response()->json(
+                ['message' => __('github-project::github-project.error.event.missing_fields')],
+                400
+            );
+        }
+
+        return null;
+    }
+
     /**
      * @param  string  $contentNodeId
      * @param  string  $message