refactor: webhook service

Author: tanhongit

src/Services/WebhookService.php

@@ -15,16 +15,42 @@ public function __construct(Client $client)
         $this->client = $client;
     }
 
-    public function eventApproved(string $event): bool
+    public function eventRequestApproved(Request $request): bool
+    {
+        $event = $request->server->get('HTTP_X_GITHUB_EVENT');
+        return $this->eventApproved((string) $event);
+    }
+
+    protected function eventApproved(string $event): bool
     {
         return str_contains($event, 'project');
     }
 
-    public function eventRequestApproved(Request $request): bool
+    protected function isActionPresent(array $payload): bool
     {
-        $event = $request->server->get('HTTP_X_GITHUB_EVENT');
+        return isset($payload['action']);
+    }
 
-        return $this->eventApproved((string) $event);
+    /**
+     * @param  array<string, mixed>  $payload
+     */
+    protected function hasValidNodeAndFieldData(array $payload): bool
+    {
+        return isset($payload['projects_v2_item']['content_node_id'], $payload['changes']['field_value']);
+    }
+
+    /**
+     * @param  array<string, mixed>  $payload
+     */
+    protected function hasFieldTemplate(array $payload): bool
+    {
+        $fieldType = $payload['changes']['field_value']['field_type'] ?? '';
+        return view()->exists('github-project::md.fields.'.$fieldType);
+    }
+
+    protected function createErrorResponse(string $message, ?int $statusCode = 400): JsonResponse
+    {
+        return response()->json(['message' => __($message)], $statusCode);
     }
 
     /**
@@ -34,35 +60,20 @@ public function eventRequestApproved(Request $request): bool
      */
     public function validatePayload(array $payload): ?JsonResponse
     {
-        if (!isset($payload['action'])) {
-            return response()->json(
-                ['message' => __('github-project::github-project.error.event.action_not_found')],
-                404
-            );
+        if (!$this->isActionPresent($payload)) {
+            return $this->createErrorResponse('github-project::github-project.error.event.action_not_found', 404);
         }
 
-        if (!$this->isStatusCommentEnabled((string) $payload['changes']['field_value']['field_name'])) {
-            return response()->json(
-                ['message' => __('github-project::github-project.error.event.status_comment_disabled')],
-                400
-            );
+        if (!$this->isStatusCommentEnabled($payload)) {
+            return $this->createErrorResponse('github-project::github-project.error.event.status_comment_disabled');
         }
 
-        $nodeId = $payload['projects_v2_item']['content_node_id'] ?? null;
-        $fieldData = $payload['changes']['field_value'] ?? null;
-
-        if (!$nodeId || !$fieldData) {
-            return response()->json(
-                ['message' => __('github-project::github-project.error.event.missing_fields')],
-                400
-            );
+        if (!$this->hasValidNodeAndFieldData($payload)) {
+            return $this->createErrorResponse('github-project::github-project.error.event.missing_fields');
         }
 
-        if (view()->exists('github-project::md.fields.'.$fieldData['field_type'])) {
-            return response()->json(
-                ['message' => __('github-project::github-project.error.event.missing_field_template')],
-                400
-            );
+        if (!$this->hasFieldTemplate($payload)) {
+            return $this->createErrorResponse('github-project::github-project.error.event.missing_field_template');
         }
 
         return null;
@@ -71,12 +82,13 @@ public function validatePayload(array $payload): ?JsonResponse
     /**
      * Check if the field name is "Status" and if status comments are enabled.
      *
-     * @param  string  $fieldName
+     * @param  array<string, mixed>  $payload
      *
      * @return bool
      */
-    public function isStatusCommentEnabled(string $fieldName): bool
+    protected function isStatusCommentEnabled(array $payload): bool
     {
+        $fieldName = (string) $payload['changes']['field_value']['field_name'] ?? '';
         if ($fieldName === 'Status' && !config('github-project.enable_status_comment')) {
             return false;
         }