refactor: PHP 8.5 + architecture improvements

- Add Platform enum and ChatTarget DTO
- Add in-memory caching for Event and Setting models
- Replace error_log() with PSR-3 LoggerInterface in Validator
- Fix EventTrait bug (was assigning string to Event object)
- Fix all implicit nullable parameter deprecations
- Add retry logic with exponential backoff for Telegram API
- Replace unsafe extract() in ConfigHelper with closure scope
- Use match expressions, readonly properties, #[NoDiscard]
- Centralize Telegram API calls in Webhook (eliminate 4x duplication)
- Add strict type comparisons throughout
- Fix test paths (storage/json/tgn/ → config/jsons/)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: tanhongit

composer.json

@@ -42,6 +42,7 @@
     "php": "^8.4|^8.5",
     "eleirbag89/telegrambotphp": "^1.4",
     "guzzlehttp/guzzle": "^7.8",
+    "psr/log": "^3.0",
     "symfony/http-foundation": "^7.0",
     "vlucas/phpdotenv": "^5.6"
   },

config/jsons/github-events.json

@@ -42,13 +42,13 @@
         /** Set the path to the data file */
         'data_file' => [
             'setting'  => $_ENV['TGN_PATH_SETTING'] ??
-                'storage/json/tgn/tgn-settings.json',
+                'config/jsons/tgn-settings.json',
 
             'platform' => [
                 'gitlab' => $_ENV['TGN_PATH_PLATFORM_GITLAB'] ??
-                    'storage/json/tgn/gitlab-events.json',
+                    'config/jsons/gitlab-events.json',
                 'github' => $_ENV['TGN_PATH_PLATFORM_GITHUB'] ??
-                    'storage/json/tgn/github-events.json',
+                    'config/jsons/github-events.json',
             ],
         ],
 

config/jsons/gitlab-events.json

@@ -39,12 +39,12 @@ class Bot implements BotInterface
      * @throws ConfigFileException
      */
     public function __construct(
-        Telegram $telegram = null,
+        ?Telegram $telegram = null,
         ?string $chatBotId = null,
-        Event $event = null,
+        ?Event $event = null,
         ?string $platform = EventConstant::DEFAULT_PLATFORM,
         ?string $platformFile = null,
-        Setting $setting = null,
+        ?Setting $setting = null,
         ?string $settingFile = null,
     ) {
         $this->event = $event ?? new Event();

config/jsons/tgn-settings.json

@@ -2,6 +2,8 @@
 
 namespace CSlant\TelegramGitNotifier\Constants;
 
+use CSlant\TelegramGitNotifier\Enums\Platform;
+
 final class EventConstant
 {
     public const DEFAULT_PLATFORM = 'github';
@@ -25,4 +27,9 @@ final class EventConstant
         'github' => self::GITHUB_EVENT_SEPARATOR,
         'gitlab' => self::GITLAB_EVENT_SEPARATOR,
     ];
+
+    public static function platformEnum(string $platform): Platform
+    {
+        return Platform::from($platform);
+    }
 }

config/tg-notifier.php

@@ -0,0 +1,50 @@
+<?php
+
+namespace CSlant\TelegramGitNotifier\DTOs;
+
+readonly class ChatTarget
+{
+    /**
+     * @param string $chatId
+     * @param list<string> $threadIds
+     */
+    public function __construct(
+        public string $chatId,
+        public array $threadIds = [],
+    ) {}
+
+    public function hasThreads(): bool
+    {
+        return $this->threadIds !== [];
+    }
+
+    /**
+     * Parse a single "chatId:thread1,thread2" string.
+     */
+    public static function fromString(string $raw): self
+    {
+        [$chatId, $threadIds] = explode(':', $raw) + [null, null];
+
+        return new self(
+            chatId: (string) $chatId,
+            threadIds: $threadIds ? explode(',', $threadIds) : [],
+        );
+    }
+
+    /**
+     * Parse "id1;id2:t1,t2;id3" format into an array of ChatTarget.
+     *
+     * @return list<self>
+     */
+    public static function parseMultiple(string $raw): array
+    {
+        if (trim($raw) === '') {
+            return [];
+        }
+
+        return array_map(
+            static fn (string $pair) => self::fromString($pair),
+            explode(';', $raw),
+        );
+    }
+}

src/Bot.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace CSlant\TelegramGitNotifier\Enums;
+
+enum Platform: string
+{
+    case GitHub = 'github';
+    case GitLab = 'gitlab';
+
+    public function eventSeparator(): string
+    {
+        return match ($this) {
+            self::GitHub => 'gh.',
+            self::GitLab => 'gl.',
+        };
+    }
+
+    public function webhookEventHeader(): string
+    {
+        return match ($this) {
+            self::GitHub => 'HTTP_X_GITHUB_EVENT',
+            self::GitLab => 'HTTP_X_GITLAB_EVENT',
+        };
+    }
+
+    /**
+     * @return array<string, string>
+     */
+    public static function webhookEventHeaders(): array
+    {
+        return array_combine(
+            array_map(fn (self $p) => $p->value, self::cases()),
+            array_map(fn (self $p) => $p->webhookEventHeader(), self::cases()),
+        );
+    }
+
+    /**
+     * @return array<string, string>
+     */
+    public static function eventSeparators(): array
+    {
+        return array_combine(
+            array_map(fn (self $p) => $p->value, self::cases()),
+            array_map(fn (self $p) => $p->eventSeparator(), self::cases()),
+        );
+    }
+
+    public static function default(): self
+    {
+        return self::GitHub;
+    }
+}

src/Constants/EventConstant.php

@@ -8,7 +8,7 @@ final class InvalidViewTemplateException extends TelegramGitNotifierException
 {
     public static function create(
         string $view,
-        Throwable $previous = null
+        ?Throwable $previous = null
     ): self {
         return new self(
             "Invalid view template: {$view}",