Add subprovider field to users & make seperate ENV variable for user visible IBAN (#1160)

* Add subprovider field to users

* fix lint

* make the option for IBAN Configarable

Author: lodewiges

.env.example

@@ -27,6 +27,8 @@ COMPANY_ADDRESS=Oude Markt 24-3, 7511 GB Enschede
 COMPANY_WEBSITE=https://societeitflux.nl
 COMPANY_KVK=41 032 169
 
+PERSONAL_TRANSACTION_IBAN=NL68 INGB 0008 1654 20
+
 SITE_NAME=S.O.F.I.A.
 SITE_SHORT_NAME=SOFIA
 SITE_LONG_NAME=Streepsysteem voor de Ordentelijke Festiviteiten van Inleggend Alpha

app/views/users/show.html.erb

@@ -117,14 +117,19 @@
                   <%= @user.credit <= 0 ? 'Je staat rood!' : 'Inleggen' %>
                 </h4>
                 <p class="card-text">
-                  <% if Rails.application.config.x.mollie_api_key.present? %>
+                  <% if Rails.application.config.x.mollie_api_key.present? && Rails.application.config.x.personal_transaction_iban.present? %>
                     Om je saldo aan te vullen kan je zelf geld overmaken of betalen met iDEAL.
-                  <% else %>
+                  <% elsif Rails.application.config.x.mollie_api_key.present? %>
+                    Om je saldo aan te vullen kan je betalen met iDEAL.
+                  <% elsif Rails.application.config.x.personal_transaction_iban.present? %>
                     Om je saldo aan te vullen kan je zelf geld overmaken.
+                  <% else %>
+                    Er is geen betaalmethode geconfigureerd om je saldo aan te vullen. Neem contact op met de penningmeester.
+                  <% end %>
+                  <% if Rails.application.config.x.personal_transaction_iban.present? %>
+                    <%= "Dat kan naar #{Rails.application.config.x.personal_transaction_iban} t.n.v. #{Rails.application.config.x.company_name}" %>
+                    <%= 'onder vermelding van je naam en \'Inleg Zatladder\'.' %>
                   <% end %>
-                  <%= "Dat kan naar #{Rails.application.config.x.company_iban} t.n.v. #{Rails.application.config.x.company_name}" %>
-                  <%= 'onder vermelding van je naam en \'Inleg Zatladder\'.' %>
-
                   <% if Rails.application.config.x.mollie_api_key.present? %>
                     <%= link_to add_payments_path do %>
                       <%= 'Klik hier om je saldo over te maken via iDEAL ' %>

config/application.rb

@@ -69,6 +69,7 @@ class Application < Rails::Application
     config.x.company_address      = ENV.fetch('COMPANY_ADDRESS', nil)
     config.x.company_website      = ENV.fetch('COMPANY_WEBSITE', nil)
     config.x.company_kvk          = ENV.fetch('COMPANY_KVK', nil)
+    config.x.personal_transaction_iban = ENV.fetch('PERSONAL_TRANSACTION_IBAN', nil)
 
     config.x.site_name            = ENV.fetch('SITE_NAME', 'S.O.F.I.A.')
     config.x.site_short_name      = ENV.fetch('SITE_SHORT_NAME', 'SOFIA')

db/migrate/20251209160709_add_user_subprovider.rb

@@ -0,0 +1,6 @@
+class AddUserSubprovider < ActiveRecord::Migration[7.2]
+  def change
+    add_column :users, :sub_provider, :string
+    add_index :users, :sub_provider
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.2].define(version: 2025_11_13_094147) do
+ActiveRecord::Schema[7.2].define(version: 2025_12_09_160709) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
@@ -182,6 +182,8 @@
     t.boolean "deactivated", default: false, null: false
     t.string "activation_token"
     t.datetime "activation_token_valid_till"
+    t.string "sub_provider"
+    t.index ["sub_provider"], name: "index_users_on_sub_provider"
     t.index ["uid"], name: "index_users_on_uid", unique: true
   end