use __destructor rather than close_files()

remove redundant setup.cfg

Author: TjarkMiener

dl1_data_handler/reader.py

@@ -16,6 +16,7 @@
 ]
 
 from abc import abstractmethod
+import atexit
 from collections import OrderedDict
 from enum import Enum
 import numpy as np
@@ -229,6 +230,8 @@ def __init__(
 
         super().__init__(config=config, parent=parent, **kwargs)
 
+        # Register the destructor to close all open files properly
+        atexit.register(self.__destructor)
         # Initialize the Table data quality query
         self.quality_query = TableQualityQuery(parent=self)
 
@@ -936,10 +939,13 @@ def generate_stereo_batch(self, batch_indices) -> Table:
         batch.sort(["obs_id", "event_id", "tel_type_id", "tel_id"])
         return batch
 
-    def close_files(self):
-        """Close all open HDF5 files."""
-        for file in self.files.values():
-            file.close()
+    def __destructor(self):
+        """Destructor to ensure all opened HDF5 files are properly closed."""
+        if hasattr(self, "files"):  # Ensure self.files exists before attempting to close
+            for file_name in list(self.files.keys()):
+                if self.files[file_name].isopen:  # Check if file is still open
+                    self.files[file_name].close()
+
 
     @abstractmethod
     def _append_features(self, batch) -> Table:

dl1_data_handler/tests/test_reader.py

@@ -21,8 +21,6 @@ def test_dl1_image_reading(dl1_tmp_path, dl1_gamma_file):
     mono_batch = dl1_reader.generate_mono_batch([0])
     assert mono_batch["tel_id"] == 4
     assert mono_batch["features"].shape == (1,  110, 110, 2)
-    # Close the files
-    dl1_reader.close_files()
 
 def test_r1_waveform_reading(r1_tmp_path, r1_gamma_file):
     """check reading from pixel-wise waveform data files"""
@@ -42,6 +40,4 @@ def test_r1_waveform_reading(r1_tmp_path, r1_gamma_file):
     # Test the generation of a mono batch
     mono_batch = r1_reader.generate_mono_batch([0])
     assert mono_batch["tel_id"] == 4
-    assert mono_batch["features"].shape == (1,  110, 110, 20)
-    # Close the files
-    r1_reader.close_files()
+    assert mono_batch["features"].shape == (1,  110, 110, 20)