Removed Fontawesome (#184)

Fontawesome was only used in the Diversification screen and all the icons could be replaced by Bootstrap Icons. That change removes one dependency, making the app lighter and providing a better unified look

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: ctasada

CHANGELOG.md

@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * Installers: Added OS name to the installer filenames
 * Improved Update Download dialog. Now shows the percentage and downloaded size
+* Changed icons used in the Diversification section. Now all the application uses the same set of icons.
 
 ### Deprecated
 

README.md

@@ -80,7 +80,6 @@ See [Wiki - Developing Stonks Overwatch](./docs/Developing-Stonks-Overwatch)
 
 ## TODOs
 
-* [ ] Migrate FontAwesome to use a [Kit](https://docs.fontawesome.com/web/use-with/python-django)
 * [ ] Add information about the sectors. Maybe a tooltip in the places where sectors are used.
 * [ ] Tables should allow choosing the number of rows to show.
 * [ ] Portfolio Tables would be migrated to "http://bootstrap-table.com/"

THIRD_PARTY_LICENSES.txt

@@ -636,176 +636,6 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 
 
-fontawesomefree
-6.6.0
-https://fontawesome.com/license/free
-Fonticons, Inc. (https://fontawesome.com)
-
---------------------------------------------------------------------------------
-
-Font Awesome Free License
-
-Font Awesome Free is free, open source, and GPL friendly. You can use it for
-commercial projects, open source projects, or really almost whatever you want.
-Full Font Awesome Free license: https://fontawesome.com/license/free.
-
---------------------------------------------------------------------------------
-
-# Icons: CC BY 4.0 License (https://creativecommons.org/licenses/by/4.0/)
-
-The Font Awesome Free download is licensed under a Creative Commons
-Attribution 4.0 International License and applies to all icons packaged
-as SVG and JS file types.
-
---------------------------------------------------------------------------------
-
-# Fonts: SIL OFL 1.1 License
-
-In the Font Awesome Free download, the SIL OFL license applies to all icons
-packaged as web and desktop font files.
-
-Copyright (c) 2024 Fonticons, Inc. (https://fontawesome.com)
-with Reserved Font Name: "Font Awesome".
-
-This Font Software is licensed under the SIL Open Font License, Version 1.1.
-This license is copied below, and is also available with a FAQ at:
-http://scripts.sil.org/OFL
-
-SIL OPEN FONT LICENSE
-Version 1.1 - 26 February 2007
-
-PREAMBLE
-The goals of the Open Font License (OFL) are to stimulate worldwide
-development of collaborative font projects, to support the font creation
-efforts of academic and linguistic communities, and to provide a free and
-open framework in which fonts may be shared and improved in partnership
-with others.
-
-The OFL allows the licensed fonts to be used, studied, modified and
-redistributed freely as long as they are not sold by themselves. The
-fonts, including any derivative works, can be bundled, embedded,
-redistributed and/or sold with any software provided that any reserved
-names are not used by derivative works. The fonts and derivatives,
-however, cannot be released under any other type of license. The
-requirement for fonts to remain under this license does not apply
-to any document created using the fonts or their derivatives.
-
-DEFINITIONS
-"Font Software" refers to the set of files released by the Copyright
-Holder(s) under this license and clearly marked as such. This may
-include source files, build scripts and documentation.
-
-"Reserved Font Name" refers to any names specified as such after the
-copyright statement(s).
-
-"Original Version" refers to the collection of Font Software components as
-distributed by the Copyright Holder(s).
-
-"Modified Version" refers to any derivative made by adding to, deleting,
-or substituting — in part or in whole — any of the components of the
-Original Version, by changing formats or by porting the Font Software to a
-new environment.
-
-"Author" refers to any designer, engineer, programmer, technical
-writer or other person who contributed to the Font Software.
-
-PERMISSION & CONDITIONS
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of the Font Software, to use, study, copy, merge, embed, modify,
-redistribute, and sell modified and unmodified copies of the Font
-Software, subject to the following conditions:
-
-1) Neither the Font Software nor any of its individual components,
-in Original or Modified Versions, may be sold by itself.
-
-2) Original or Modified Versions of the Font Software may be bundled,
-redistributed and/or sold with any software, provided that each copy
-contains the above copyright notice and this license. These can be
-included either as stand-alone text files, human-readable headers or
-in the appropriate machine-readable metadata fields within text or
-binary files as long as those fields can be easily viewed by the user.
-
-3) No Modified Version of the Font Software may use the Reserved Font
-Name(s) unless explicit written permission is granted by the corresponding
-Copyright Holder. This restriction only applies to the primary font name as
-presented to the users.
-
-4) The name(s) of the Copyright Holder(s) or the Author(s) of the Font
-Software shall not be used to promote, endorse or advertise any
-Modified Version, except to acknowledge the contribution(s) of the
-Copyright Holder(s) and the Author(s) or with their explicit written
-permission.
-
-5) The Font Software, modified or unmodified, in part or in whole,
-must be distributed entirely under this license, and must not be
-distributed under any other license. The requirement for fonts to
-remain under this license does not apply to any document created
-using the Font Software.
-
-TERMINATION
-This license becomes null and void if any of the above conditions are
-not met.
-
-DISCLAIMER
-THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT
-OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE
-COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
-INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL
-DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
-FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM
-OTHER DEALINGS IN THE FONT SOFTWARE.
-
---------------------------------------------------------------------------------
-
-# Code: MIT License (https://opensource.org/licenses/MIT)
-
-In the Font Awesome Free download, the MIT license applies to all non-font and
-non-icon files.
-
-Copyright 2024 Fonticons, Inc.
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of
-this software and associated documentation files (the "Software"), to deal in the
-Software without restriction, including without limitation the rights to use, copy,
-modify, merge, publish, distribute, sublicense, and/or sell copies of the Software,
-and to permit persons to whom the Software is furnished to do so, subject to the
-following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
-INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A
-PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
-HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
-SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
---------------------------------------------------------------------------------
-
-# Attribution
-
-Attribution is required by MIT, SIL OFL, and CC BY licenses. Downloaded Font
-Awesome Free files already contain embedded comments with sufficient
-attribution, so you shouldn't need to do anything additional when using these
-files normally.
-
-We've kept attribution comments terse, so we ask that you do not actively work
-to remove them from files, especially code. They're a great way for folks to
-learn about Font Awesome.
-
---------------------------------------------------------------------------------
-
-# Brand Icons
-
-All brand icons are trademarks of their respective owners. The use of these
-trademarks does not indicate endorsement of the trademark holder by Font
-Awesome, nor vice versa. **Please do not use brand logos for any purpose except
-to represent the company, product, or service to which they refer.**
-
-
 fonttools
 4.59.1
 MIT

docs/User-Interface.md

@@ -5,7 +5,6 @@ The user interface of **Stonks Overwatch** is build with the next technologies:
 - [Bootstrap](https://getbootstrap.com) for the CSS framework
 - [Bootstrap Table](https://bootstrap-table.com/) for the tables
 - [Bootstrap Icons](https://icons.getbootstrap.com/) for the icons
-- [Font Awesome](https://fontawesome.com/) for additional icons
 - [Charts.js](https://www.chartjs.org/) for the charts
 - [Toga](https://toga.readthedocs.io/en/stable/) for the native application
 

poetry.lock

@@ -22,7 +22,6 @@ dependencies = [
     "yfinance >= 0.2.65",
     "iso10383 >=2025.2.10",
     "requests >=2.32.4",
-    "fontawesomefree >= 6.6.0",
     "ibind[oauth] >=0.1.19",
     "cryptography >=45.0.6",
     "packaging >=25.0",
@@ -266,7 +265,7 @@ known_first_party = ["stonks_overwatch"]
 [tool.deptry.per_rule_ignores]
 # django-extensions are not actively used in the codebase, but it can be useful
 # django-node-assets is used to simplify the management of NPM dependencies
-DEP002 = ["django-extensions", "django-node-assets", "fontawesomefree"]
+DEP002 = ["django-extensions", "django-node-assets"]
 
 [tool.bandit]
 exclude_dirs = ["build", ".venv"]

pyproject.toml

@@ -68,7 +68,6 @@
     "stonks_overwatch.app_config.StonksOverwatchConfig",
     "django_extensions",
     "django_node_assets",
-    "fontawesomefree",
 ]
 
 MIDDLEWARE = [

src/stonks_overwatch/settings.py

@@ -9,13 +9,16 @@
                 <div class="diversification-weight">
                     <div class="d-flex align-items-center">
                         {% if item.product_type %}
+                            <div class="ratio ratio-1x1 d-inline-flex align-items-center justify-content-center
+            bg-white border border-primary rounded-circle" style="width: 2.5rem; height: 2.5rem;">
                             {% if item.product_type == 'sector' %}
-                                <i class="fas fa-{{ item.symbol }} bg-white rounded-circle border border-primary p-2"></i>
+                                <i class="bi bi-{{ item.symbol }} fs-4" style="display: flex; align-items: center; justify-content: center;"></i>
                             {% elif item.product_type == 'cash' %}
-                                <i class="fas fa-{{ item.symbol }} bg-white rounded-circle border border-primary p-2"></i>
+                                <i class="bi bi-{{ item.symbol }} fs-4" style="display: flex; align-items: center; justify-content: center;"></i>
                             {% else %}
-                                <img class="rounded-circle bg-white border border-primary" src="{% url 'asset_logo' product_type=item.product_type|lower symbol=item.symbol|lower %}" width="30" height="30" alt="{{ item.symbol }} logo" onerror="this.style.display='none'">
+                                <img src="{% url 'asset_logo' product_type=item.product_type|lower symbol=item.symbol|lower %}" width="30" height="30" alt="{{ item.symbol }} logo" onerror="this.style.display='none'">
                             {% endif %}
+                            </div>
                         {% endif %}
                     </div>
                     <div class="p-2 me-auto">{{ item.name }}</div>

src/stonks_overwatch/templates/components/distribution_with_list.html

@@ -3,10 +3,6 @@
 {% load static %}
 {% block content %}
 
-<!-- Font Awesome JS -->
-<script src="{% static 'fontawesomefree/js/solid.js' %}"></script>
-<script src="{% static 'fontawesomefree/js/fontawesome.js' %}"></script>
-
 <div class="container-fluid row-gap-5">
     {% include 'components/distribution_with_list.html' with chart_id="type-chart" items=productTypes.table %}
     {% if positions and positions.table %}

src/stonks_overwatch/templates/diversification.html

@@ -51,13 +51,13 @@ <h3 class="text-center mb-4">Login - DEGIRO</h3>
                         {% for message in messages %}
                             <div class="alert {% if message.level == DEFAULT_MESSAGE_LEVELS.ERROR %}alert-danger{% elif message.level == DEFAULT_MESSAGE_LEVELS.WARNING %}alert-warning{% elif message.level == DEFAULT_MESSAGE_LEVELS.SUCCESS %}alert-success{% else %}alert-info{% endif %} d-flex align-items-start py-2 mb-2" role="alert" style="word-break: break-word;">
                                 {% if message.level == DEFAULT_MESSAGE_LEVELS.ERROR %}
-                                    <i class="bi-exclamation-triangle-fill me-2 mt-1"></i>
+                                    <i class="bi bi-exclamation-triangle-fill me-2 mt-1"></i>
                                 {% elif message.level == DEFAULT_MESSAGE_LEVELS.WARNING %}
-                                    <i class="bi-exclamation-circle-fill me-2 mt-1"></i>
+                                    <i class="bi bi-exclamation-circle-fill me-2 mt-1"></i>
                                 {% elif message.level == DEFAULT_MESSAGE_LEVELS.SUCCESS %}
-                                    <i class="bi-check-circle-fill me-2 mt-1"></i>
+                                    <i class="bi bi-check-circle-fill me-2 mt-1"></i>
                                 {% else %}
-                                    <i class="bi-info-circle-fill me-2 mt-1"></i>
+                                    <i class="bi bi-info-circle-fill me-2 mt-1"></i>
                                 {% endif %}
                                 <div class="flex-grow-1">{{ message|safe }}</div>
                             </div>
@@ -74,7 +74,7 @@ <h3 class="text-center mb-4">Login - DEGIRO</h3>
                     <button type="submit" class="btn btn-primary btn-block w-100">Confirm</button>
                 {% elif show_in_app_auth %}
                     <div class="d-flex align-items-center py-3 mb-4">
-                        <i class="bi-phone me-3" style="font-size: 2rem; color: #0d6efd;"></i>
+                        <i class="bi bi-phone me-3" style="font-size: 2rem; color: #0d6efd;"></i>
                         <div class="flex-grow-1">
                             <p class="mb-0">To verify your login attempt, open the DEGIRO app and tap 'Yes' to approve it.</p>
                         </div>
@@ -118,7 +118,7 @@ <h3 class="text-center mb-4">Login - DEGIRO</h3>
                         <div class="input-group">
                             <input type="password" class="form-control" id="password" name="password"
                                    placeholder="Enter password" required>
-                            <i class="bi-eye-slash-fill" id="togglePassword"></i>
+                            <i class="bi bi-eye-slash-fill" id="togglePassword"></i>
                         </div>
                     </div>
                     <div class="form-group mb-3">