feat: Indicator of last update for each broker (#325)

* feat: Indicator of last update for each broker

Until now only DEGIRO was showing an indicator of when was the last update. Now this indicator shows the information of all enabled brokers.

The indicator has been also improved to show cleaner information

* fix: Fixed sidebar horizontal separator

Author: ctasada

CHANGELOG.md

@@ -13,6 +13,7 @@ _This project follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) a
 ### Changed
 
 - Internal refactor to simplify the authentication processes across different brokers
+- Last update indicator now shows information for all the brokers
 
 ### Fixed
 

src/stonks_overwatch/core/factories/broker_registry.py

@@ -20,6 +20,7 @@
     PortfolioServiceInterface,
     TransactionServiceInterface,
 )
+from stonks_overwatch.core.interfaces.update_service import AbstractUpdateService
 from stonks_overwatch.core.service_types import ServiceType
 from stonks_overwatch.utils.core.logger import StonksLogger
 from stonks_overwatch.utils.core.singleton import singleton
@@ -51,6 +52,7 @@ class BrokerRegistry:
         ServiceType.FEE: FeeServiceInterface,
         ServiceType.ACCOUNT: AccountServiceInterface,
         ServiceType.AUTHENTICATION: AuthenticationServiceInterface,
+        ServiceType.UPDATE: AbstractUpdateService,
     }
 
     def __init__(self):

src/stonks_overwatch/core/interfaces/update_service.py

@@ -1,9 +1,11 @@
 import os
 import time as core_time
 from abc import ABC, abstractmethod
+from datetime import datetime
 from typing import Optional
 
 from django.db.utils import OperationalError
+from django.utils import timezone
 
 from stonks_overwatch.config.base_config import BaseConfig
 from stonks_overwatch.constants import BrokerName
@@ -132,6 +134,45 @@ def _retry_database_operation(self, operation, *args, max_retries=3, delay=0.1,
 
         raise last_exception
 
+    def _record_sync(self, success: bool = True) -> None:
+        """
+        Record that a sync attempt completed for this broker.
+
+        Should be called at the end of update_all() to track the last time the broker
+        data was refreshed from the external API, regardless of whether new data existed.
+
+        Args:
+            success: True if the sync completed without errors, False otherwise
+        """
+        from stonks_overwatch.core.models import BrokerSyncLog
+
+        try:
+            BrokerSyncLog.objects.create(
+                broker_name=self.broker_name,
+                synced_at=timezone.now(),
+                success=success,
+            )
+        except Exception as e:
+            self.logger.error("Failed to record sync log for %s: %s", self.broker_name, str(e))
+
+    def get_last_sync(self) -> Optional[datetime]:
+        """
+        Return the last time this broker was successfully synced with the external API.
+
+        Returns:
+            Datetime of the last successful sync, or None if no sync has been recorded yet
+        """
+        from stonks_overwatch.core.models import BrokerSyncLog
+
+        try:
+            entry = (
+                BrokerSyncLog.objects.filter(broker_name=self.broker_name, success=True).order_by("-synced_at").first()
+            )
+            return entry.synced_at if entry else None
+        except Exception as e:
+            self.logger.error("Failed to get last sync for %s: %s", self.broker_name, str(e))
+            return None
+
     @abstractmethod
     def update_all(self):
         pass

src/stonks_overwatch/core/models.py

@@ -1,8 +1,32 @@
 from django.db import models
+from django.utils import timezone
 
 from stonks_overwatch.utils.core.logger import StonksLogger
 
 
+class BrokerSyncLog(models.Model):
+    """
+    Tracks the last time each broker's data was successfully refreshed from the external API.
+
+    This provides accurate "last refreshed" timestamps independent of when the most
+    recent transaction or business event occurred.
+    """
+
+    class Meta:
+        db_table = "broker_sync_log"
+        verbose_name = "Broker Sync Log"
+        verbose_name_plural = "Broker Sync Logs"
+        get_latest_by = "synced_at"
+
+    broker_name = models.CharField(max_length=50, db_index=True)
+    synced_at = models.DateTimeField(default=timezone.now)
+    success = models.BooleanField(default=True)
+
+    def __str__(self) -> str:
+        status = "success" if self.success else "failed"
+        return f"{self.broker_name}: {self.synced_at} ({status})"
+
+
 class GlobalConfiguration(models.Model):
     """
     Model for storing global application configuration settings.

src/stonks_overwatch/core/registry_setup.py

@@ -47,6 +47,7 @@
 from stonks_overwatch.services.brokers.bitvavo.services.transaction_service import (
     TransactionsService as BitvavoTransactionService,
 )
+from stonks_overwatch.services.brokers.bitvavo.services.update_service import UpdateService as BitvavoUpdateService
 from stonks_overwatch.services.brokers.degiro.services.account_service import (
     AccountOverviewService as DeGiroAccountService,
 )
@@ -64,6 +65,7 @@
 from stonks_overwatch.services.brokers.degiro.services.transaction_service import (
     TransactionsService as DeGiroTransactionService,
 )
+from stonks_overwatch.services.brokers.degiro.services.update_service import UpdateService as DeGiroUpdateService
 from stonks_overwatch.services.brokers.ibkr.services.account_overview import (
     AccountOverviewService as IbkrAccountOverviewService,
 )
@@ -86,6 +88,7 @@
 from stonks_overwatch.services.brokers.ibkr.services.transactions import (
     TransactionsService as IbkrTransactionService,
 )
+from stonks_overwatch.services.brokers.ibkr.services.update_service import UpdateService as IbkrUpdateService
 
 # Configuration-driven broker definitions
 BROKER_CONFIGS: Dict[BrokerName, Dict[str, Any]] = {
@@ -99,6 +102,7 @@
             ServiceType.FEE: DeGiroFeeService,
             ServiceType.ACCOUNT: DeGiroAccountService,
             ServiceType.AUTHENTICATION: DegiroAuthenticationService,
+            ServiceType.UPDATE: DeGiroUpdateService,
         },
     },
     BrokerName.BITVAVO: {
@@ -110,6 +114,7 @@
             ServiceType.FEE: BitvavoFeeService,
             ServiceType.ACCOUNT: BitvavoAccountService,
             ServiceType.AUTHENTICATION: BitvavoAuthenticationService,
+            ServiceType.UPDATE: BitvavoUpdateService,
         },
     },
     BrokerName.IBKR: {
@@ -120,6 +125,7 @@
             ServiceType.DIVIDEND: IbkrDividendsService,
             ServiceType.ACCOUNT: IbkrAccountOverviewService,
             ServiceType.AUTHENTICATION: IbkrAuthenticationService,
+            ServiceType.UPDATE: IbkrUpdateService,
         },
     },
 }

src/stonks_overwatch/core/service_types.py

@@ -18,3 +18,4 @@ class ServiceType(Enum):
     FEE = "fee"
     ACCOUNT = "account"
     AUTHENTICATION = "authentication"
+    UPDATE = "update"

src/stonks_overwatch/migrations/0010_brokersynclog.py

@@ -0,0 +1,27 @@
+import django.db.models.deletion
+import django.utils.timezone
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("stonks_overwatch", "0009_globalconfiguration"),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name="BrokerSyncLog",
+            fields=[
+                ("id", models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name="ID")),
+                ("broker_name", models.CharField(db_index=True, max_length=50)),
+                ("synced_at", models.DateTimeField(default=django.utils.timezone.now)),
+                ("success", models.BooleanField(default=True)),
+            ],
+            options={
+                "verbose_name": "Broker Sync Log",
+                "verbose_name_plural": "Broker Sync Logs",
+                "db_table": "broker_sync_log",
+                "get_latest_by": "synced_at",
+            },
+        ),
+    ]

src/stonks_overwatch/services/brokers/bitvavo/services/update_service.py

@@ -59,9 +59,11 @@ def update_all(self):
             self.update_transactions()
             self.update_portfolio()
             self.update_assets()
+            self._record_sync(success=True)
         except Exception as error:
             self.logger.error("Cannot Update Portfolio!")
             self.logger.error("Exception: %s", str(error), exc_info=True)
+            self._record_sync(success=False)
 
     def update_portfolio(self):
         self._log_message("Updating Portfolio Data....")

src/stonks_overwatch/services/brokers/degiro/services/update_service.py

@@ -26,9 +26,6 @@
     DeGiroUpcomingPayments,
 )
 from stonks_overwatch.services.brokers.degiro.repositories.product_info_repository import ProductInfoRepository
-from stonks_overwatch.services.brokers.degiro.repositories.product_quotations_repository import (
-    ProductQuotationsRepository,
-)
 from stonks_overwatch.services.brokers.degiro.repositories.transactions_repository import TransactionsRepository
 from stonks_overwatch.services.brokers.degiro.services.helper import is_non_tradeable_product
 from stonks_overwatch.services.brokers.degiro.services.portfolio_service import PortfolioService
@@ -89,20 +86,6 @@ def __init__(
         )
         self.yfinance_client = YFinanceClient()
 
-    def get_last_import(self) -> datetime:
-        last_cash_movement = self._get_last_cash_movement_import()
-        last_transaction = self._get_last_transactions_import()
-        last_quotation = ProductQuotationsRepository.get_last_update()
-
-        # Filter out None values to handle cases where no data exists yet
-        non_null_dates = [date for date in [last_cash_movement, last_transaction, last_quotation] if date is not None]
-
-        if not non_null_dates:
-            # If no data exists yet, return a timezone-aware default date
-            return django_timezone.now()
-
-        return max(non_null_dates)
-
     def _get_last_cash_movement_import(self) -> datetime:
         last_movement = CashMovementsRepository.get_last_movement()
         return self._ensure_timezone_aware_datetime(last_movement)
@@ -154,9 +137,11 @@ def update_all(self):
             self.update_company_profile()
             self.update_yfinance()
             self.update_dividends()
+            self._record_sync(success=True)
         except Exception as error:
             self.logger.error("Cannot Update Portfolio!")
             self.logger.error("Exception: %s", str(error), exc_info=True)
+            self._record_sync(success=False)
 
     def update_account(self):
         """Update the Account DB data. Only does it if the data is older than today."""

src/stonks_overwatch/services/brokers/ibkr/services/update_service.py

@@ -51,9 +51,11 @@ def update_all(self):
         try:
             self.update_portfolio()
             self.update_transactions()
+            self._record_sync(success=True)
         except Exception as error:
             self.logger.error("Cannot Update Portfolio!")
             self.logger.error("Exception: %s", str(error), exc_info=True)
+            self._record_sync(success=False)
 
     def update_portfolio(self):
         """Updating the Portfolio is an expensive and time-consuming task.