Skip to content

Commit 6bd52b7

Browse files
authored
Merge pull request #22 from stephenlacy/allcaps
Add support for all caps boolean values
2 parents 5b02fee + 14aca9f commit 6bd52b7

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,12 @@ const convert = {
5353
return +value;
5454
},
5555
bool: function(value) {
56-
const isBool = value === 'true' || value === 'false';
56+
const isBool = (value || '').toLowerCase() === 'true' || (value || '').toLowerCase() === 'false';
5757
if (!isBool) {
5858
throw new Error('GetEnv.NoBoolean: ' + value + ' is not a boolean.');
5959
}
6060

61-
return value === 'true';
61+
return (value || '').toLowerCase() === 'true';
6262
},
6363
boolish: function(value) {
6464
try {

test/getenv.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ process.env.TEST_GETENV_FLOAT2 = '0.0';
1313
process.env.TEST_GETENV_INFINITY1 = Infinity;
1414
process.env.TEST_GETENV_INFINITY2 = -Infinity;
1515
process.env.TEST_GETENV_FALSE = 'false';
16+
process.env.TEST_GETENV_FALSE2 = 'FALSE';
1617
process.env.TEST_GETENV_TRUE = 'true';
18+
process.env.TEST_GETENV_TRUE2 = 'TRUE';
1719
process.env.TEST_GETENV_NOT_REALLY_TRUE = '1';
1820
process.env.TEST_GETENV_NOT_REALLY_FALSE = '0';
1921
process.env.TEST_GETENV_WRONG_NUMBER_INPUT = '3 test';
@@ -202,10 +204,18 @@ tests['getenv.bool() valid input'] = function() {
202204
varName: 'TEST_GETENV_FALSE',
203205
expected: false,
204206
},
207+
{
208+
varName: 'TEST_GETENV_FALSE2',
209+
expected: false,
210+
},
205211
{
206212
varName: 'TEST_GETENV_TRUE',
207213
expected: true,
208214
},
215+
{
216+
varName: 'TEST_GETENV_TRUE2',
217+
expected: true,
218+
},
209219
];
210220

211221
data.forEach(function(item) {

0 commit comments

Comments
 (0)