Use const/let instead of var

Author: ctavan

README.md

@@ -28,31 +28,31 @@ export PRIMES="2,3,5,7"
 Get and use them:
 
 ```javascript
-var getenv = require('getenv');
+const getenv = require('getenv');
 
-var host = getenv('HTTP_HOST'); // same as getenv.string('HTTP_HOST');
-var port = getenv.int('HTTP_PORT');
-var start = getenv.bool('HTTP_START');
+const host = getenv('HTTP_HOST'); // same as getenv.string('HTTP_HOST');
+const port = getenv.int('HTTP_PORT');
+const start = getenv.bool('HTTP_START');
 
 if (start === true) {
-  // var server = http.createServer();
+  // const server = http.createServer();
   // server.listen(port, host);
 }
 
-var abTestRatio = getenv.float('AB_TEST_RATIO');
+const abTestRatio = getenv.float('AB_TEST_RATIO');
 
 if (Math.random() < abTestRatio) {
   // test A
 } else {
   // test B
 }
 
-var keywords = getenv.array('KEYWORDS');
+const keywords = getenv.array('KEYWORDS');
 keywords.forEach(function(keyword) {
   // console.log(keyword);
 });
 
-var primes = getenv.array('PRIMES', 'int');
+const primes = getenv.array('PRIMES', 'int');
 primes.forEach(function(prime) {
   // console.log(prime, typeof prime);
 });
@@ -95,7 +95,7 @@ Split value of the environment variable at each comma and return the resulting a
 Return a list of environment variables based on a `spec`:
 
 ```javascript
-var config = getenv.multi({
+const config = getenv.multi({
   foo: 'FOO', // throws if FOO doesn't exist
   bar: ['BAR', 'defaultval'], // set a default value
   baz: ['BAZ', 'defaultval', 'string'], // parse into type
@@ -108,7 +108,7 @@ var config = getenv.multi({
 Return a parsed URL as per Node's `require("url").parse`. N.B `url` doesn't validate URLs, so be sure it includes a protocol or you'll get deeply weird results.
 
 ```javascript
-var serviceUrl = getenv.url('SERVICE_URL');
+const serviceUrl = getenv.url('SERVICE_URL');
 
 serviceUrl.port; // parsed port number
 ```

index.js

@@ -1,11 +1,11 @@
-var util = require('util');
-var url = require('url');
+const util = require('util');
+const url = require('url');
 
-var fallbacksDisabled = false;
-var throwError = true;
+let fallbacksDisabled = false;
+let throwError = true;
 
 function _value(varName, fallback) {
-  var value = process.env[varName];
+  const value = process.env[varName];
   if (value === undefined) {
     if (fallback === undefined && !throwError) {
       return value;
@@ -28,33 +28,33 @@ function _value(varName, fallback) {
   return value;
 }
 
-var convert = {
+const convert = {
   string: function(value) {
     return '' + value;
   },
   int: function(value) {
-    var isInt = value.match(/^-?\d+$/);
+    const isInt = value.match(/^-?\d+$/);
     if (!isInt) {
       throw new Error('GetEnv.NoInteger: ' + value + ' is not an integer.');
     }
 
     return +value;
   },
   float: function(value) {
-    var isInfinity = +value === Infinity || +value === -Infinity;
+    const isInfinity = +value === Infinity || +value === -Infinity;
     if (isInfinity) {
       throw new Error('GetEnv.Infinity: ' + value + ' is set to +/-Infinity.');
     }
 
-    var isFloat = !(isNaN(value) || value === '');
+    const isFloat = !(isNaN(value) || value === '');
     if (!isFloat) {
       throw new Error('GetEnv.NoFloat: ' + value + ' is not a number.');
     }
 
     return +value;
   },
   bool: function(value) {
-    var isBool = value === 'true' || value === 'false';
+    const isBool = value === 'true' || value === 'false';
     if (!isBool) {
       throw new Error('GetEnv.NoBoolean: ' + value + ' is not a boolean.');
     }
@@ -65,7 +65,7 @@ var convert = {
     try {
       return convert.bool(value);
     } catch (err) {
-      var isBool = value === '1' || value === '0';
+      const isBool = value === '1' || value === '0';
       if (!isBool) {
         throw new Error('GetEnv.NoBoolean: ' + value + ' is not a boolean.');
       }
@@ -80,7 +80,7 @@ function converter(type) {
   return function(varName, fallback) {
     if (typeof varName == 'string') {
       // default
-      var value = _value(varName, fallback);
+      const value = _value(varName, fallback);
       return convert[type](value);
     } else {
       // multibert!
@@ -89,7 +89,7 @@ function converter(type) {
   };
 }
 
-var getenv = converter('string');
+const getenv = converter('string');
 
 Object.keys(convert).forEach(function(type) {
   getenv[type] = converter(type);
@@ -100,15 +100,14 @@ getenv.array = function array(varName, type, fallback) {
   if (Object.keys(convert).indexOf(type) === -1) {
     throw new Error('GetEnv.ArrayUndefinedType: Unknown array type ' + type);
   }
-  var value = _value(varName, fallback);
+  const value = _value(varName, fallback);
   return value.split(/\s*,\s*/).map(convert[type]);
 };
 
 getenv.multi = function multi(spec) {
-  var key, value;
-  var result = {};
-  for (var key in spec) {
-    var value = spec[key];
+  const result = {};
+  for (let key in spec) {
+    const value = spec[key];
     if (util.isArray(value)) {
       // default value & typecast
       switch (value.length) {

test/disableErrors.js

@@ -1,8 +1,8 @@
-var assert = require('assert');
+const assert = require('assert');
 
-var getenv = require('../index');
+const getenv = require('../index');
 
-var tests = {};
+const tests = {};
 
 tests['getenv.disableErrors() should disable any errors'] = function() {
   getenv.disableErrors();

test/fallbacks.js

@@ -1,8 +1,8 @@
-var assert = require('assert');
+const assert = require('assert');
 
-var getenv = require('../index');
+const getenv = require('../index');
 
-var tests = {};
+const tests = {};
 
 // order dependent test
 tests['getenv.disableFallbacks() makes relying on fallbacks an error'] = function() {