fix(#241): add destroy-if-non-empty flag (#257)

Signed-off-by: Lucas Tesson <lucastesson@protonmail.com>

Author: pandatix

action.yaml

@@ -24,6 +24,8 @@ inputs:
     description: 'List of configurations tuples (<key> <value>) to pass to the Pulumi entrypoint. Does not support secrets yet.'
   outputs:
     description: 'Where to write the Pulumi stack outputs. If set to "-" will write to stdout, else to the given filename.'
+  destroy-if-non-empty:
+    description: 'If set to true, and the update plan is non-empty, destroy EVERYHTING first. Use with caution.'
 
 runs:
   using: docker
@@ -39,3 +41,4 @@ runs:
     RESOURCES: ${{ inputs.resources }}
     CONFIGURATION: ${{ inputs.configuration }}
     OUTPUTS: ${{ inputs.outputs }}
+    DESTROY_IF_NON_EMPTY: ${{ inputs.destroy-if-non-empty }}

cmd/victor/main.go

@@ -104,6 +104,13 @@ func main() {
 				Required: false,
 				Sources:  cli.EnvVars("OUTPUTS", "PLUGIN_OUTPUTS"),
 			},
+			&cli.BoolFlag{
+				Name:     "destroy-if-non-empty",
+				Category: catPulumi,
+				Usage:    "If set to true, and the update plan is non-empty, destroy EVERYHTING first. Use with caution.",
+				Required: false,
+				Sources:  cli.EnvVars("DESTROY_IF_NON_EMPTY", "PLUGIN_DESTROY_IF_NON_EMPTY"),
+			},
 		},
 		Action: run,
 		Authors: []any{
@@ -133,17 +140,18 @@ func main() {
 func run(ctx context.Context, cmd *cli.Command) error {
 	// Build SDK arguments
 	args := &victor.VictorArgs{
-		Verbose:       cmd.Bool("verbose"),
-		Version:       version,
-		Statefile:     cmd.String("statefile"),
-		Username:      ptrCli(cmd, "username"),
-		Password:      ptrCli(cmd, "password"),
-		Passphrase:    cmd.String("passphrase"),
-		Context:       cmd.String("context"),
-		Server:        ptrCli(cmd, "server"),
-		Resources:     cmd.StringSlice("resources"),
-		Configuration: cmd.StringSlice("configuration"),
-		Outputs:       ptrCli(cmd, "outputs"),
+		Verbose:           cmd.Bool("verbose"),
+		Version:           version,
+		Statefile:         cmd.String("statefile"),
+		Username:          ptrCli(cmd, "username"),
+		Password:          ptrCli(cmd, "password"),
+		Passphrase:        cmd.String("passphrase"),
+		Context:           cmd.String("context"),
+		Server:            ptrCli(cmd, "server"),
+		Resources:         cmd.StringSlice("resources"),
+		Configuration:     cmd.StringSlice("configuration"),
+		Outputs:           ptrCli(cmd, "outputs"),
+		DestroyIfNonEmpty: cmd.Bool("destroy-if-non-empty"),
 	}
 	return victor.Victor(ctx, args)
 }

http.go

@@ -36,11 +36,15 @@ func (client *Client) Do(req *http.Request) (*http.Response, error) {
 		)
 	}
 
-	req.Header.Set("User-Agent", fmt.Sprintf("CTFer.io Victor (%s)", client.version))
+	req.Header.Set("User-Agent", client.UserAgent())
 	if client.username != nil && client.password != nil {
 		bauth := fmt.Sprintf("%s:%s", *client.username, *client.password)
 		bauth = base64.StdEncoding.EncodeToString([]byte(bauth))
 		req.Header.Set("Authorization", fmt.Sprintf("Basic %s", bauth))
 	}
 	return client.sub.Do(req)
 }
+
+func (client *Client) UserAgent() string {
+	return fmt.Sprintf("CTFer.io Victor (%s)", client.version)
+}

outputs.go

@@ -6,16 +6,25 @@ import (
 	"os"
 
 	"github.com/pulumi/pulumi/sdk/v3/go/auto"
+	"go.uber.org/zap"
 )
 
 // ExportOutputs writes the Pulumi stack outputs to stdout or in a file.
-func ExportOutputs(outputs auto.OutputMap, dst string) error {
+func (args *VictorArgs) Export(outputs auto.OutputMap) error {
+	if args.Outputs == nil {
+		return nil
+	}
+
 	out, _ := json.Marshal(outputs)
-	if dst == "-" {
+	if *args.Outputs == "-" {
 		fmt.Printf("%s\n", out)
 		return nil
 	}
 
-	fmt.Printf("Writing outputs to %s", dst)
-	return os.WriteFile(dst, out, 0644)
+	if args.Verbose {
+		Log().Info("writing outputs",
+			zap.String("destination", *args.Outputs),
+		)
+	}
+	return os.WriteFile(*args.Outputs, out, 0644)
 }

stack.go

@@ -13,7 +13,7 @@ import (
 
 // GetStack fetches the Pulumi stack state file from the provided url,
 // and if it does not exist, create a brand new one.
-func GetStack(ctx context.Context, client *Client, ws auto.Workspace, url string, verbose bool) (auto.Stack, error) {
+func GetStack(ctx context.Context, cli *Client, ws auto.Workspace, url string, verbose bool) (auto.Stack, error) {
 	// TODO extract the stack from the url ? or the workspace ?
 	stackName := "victor"
 	logger := Log()
@@ -26,20 +26,21 @@ func GetStack(ctx context.Context, client *Client, ws auto.Workspace, url string
 
 	// Get state from webserver if exist
 	req, _ := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
-	res, err := client.Do(req)
+	res, err := cli.Do(req)
 	if err != nil {
 		return auto.Stack{}, errors.Wrapf(err, "while fetching %s", url)
 	}
 	defer func() {
 		_ = res.Body.Close()
-
 	}()
+
 	if res.StatusCode == http.StatusNotFound {
 		if verbose {
 			logger.Info("stack file not found, starting from a brand new one")
 		}
 		return stack, nil
 	}
+
 	if verbose {
 		logger.Info("loading existing stack")
 	}

victor.go

@@ -7,23 +7,26 @@ import (
 
 	"github.com/pkg/errors"
 	"github.com/pulumi/pulumi/sdk/v3/go/auto"
+	"github.com/pulumi/pulumi/sdk/v3/go/auto/optdestroy"
+	"github.com/pulumi/pulumi/sdk/v3/go/auto/optrefresh"
 	"github.com/pulumi/pulumi/sdk/v3/go/auto/optup"
 	"go.uber.org/multierr"
 	"go.uber.org/zap"
 )
 
 type VictorArgs struct {
-	Verbose       bool
-	Version       string
-	Statefile     string
-	Username      *string
-	Password      *string
-	Passphrase    string
-	Context       string
-	Server        *string
-	Resources     []string
-	Configuration []string
-	Outputs       *string
+	Verbose           bool
+	Version           string
+	Statefile         string
+	Username          *string
+	Password          *string
+	Passphrase        string
+	Context           string
+	Server            *string
+	Resources         []string
+	Configuration     []string
+	Outputs           *string
+	DestroyIfNonEmpty bool
 }
 
 func Victor(ctx context.Context, args *VictorArgs) error {
@@ -34,8 +37,8 @@ func Victor(ctx context.Context, args *VictorArgs) error {
 	}
 	logger := Log()
 
-	// Build Victor's client
-	client := NewClient(args.Version, args.Verbose, args.Username, args.Password)
+	// Build Victor's cli
+	cli := NewClient(args.Version, args.Verbose, args.Username, args.Password)
 
 	// Create the workspace
 	if args.Verbose {
@@ -69,7 +72,7 @@ func Victor(ctx context.Context, args *VictorArgs) error {
 	if args.Verbose {
 		logger.Info("getting the stack")
 	}
-	stack, err := GetStack(ctx, client, ws, args.Statefile, args.Verbose)
+	stack, err := GetStack(ctx, cli, ws, args.Statefile, args.Verbose)
 	if err != nil {
 		return err
 	}
@@ -86,35 +89,44 @@ func Victor(ctx context.Context, args *VictorArgs) error {
 	}
 
 	// Refresh and update
-	upopts := []optup.Option{}
+	upopts := []optup.Option{
+		optup.UserAgent(cli.UserAgent()),
+	}
 	if args.Verbose {
 		logger.Info("refreshing and updating Pulumi stack")
 		zw := &ZapWriter{logger: logger}
 		upopts = append(upopts, optup.ProgressStreams(zw))
 	}
-	_, err = stack.Refresh(ctx)
+
+	// Make sure to properly track resources and changes
+	refRes, err := stack.Refresh(ctx, optrefresh.UserAgent(cli.UserAgent()))
 	if err != nil {
 		return errors.Wrap(err, "refreshing Pulumi stack")
 	}
+	if refRes.Summary.ResourceChanges != nil && len(*refRes.Summary.ResourceChanges) != 0 {
+		if _, err := stack.Destroy(ctx, optdestroy.UserAgent(cli.UserAgent())); err != nil {
+			return errors.Wrap(err, "destroying Pulumi stack ahead of update")
+		}
+	}
+
+	// Up(date) the stack
 	res, err := stack.Up(ctx, upopts...)
 	if err != nil {
 		return errors.Wrap(err, "stack up")
 	}
 
 	// Export outputs
-	if args.Outputs != nil {
-		if err := ExportOutputs(res.Outputs, *args.Outputs); err != nil {
-			logger.Error("exporting outputs",
-				zap.Error(err),
-			)
-		}
+	if err := args.Export(res.Outputs); err != nil {
+		logger.Error("exporting outputs",
+			zap.Error(err),
+		)
 	}
 
 	// Export stack
 	if args.Verbose {
-		logger.Info("pushing the stack")
+		logger.Info("pushing stack")
 	}
-	return PushStack(ctx, client, stack, args.Statefile)
+	return PushStack(ctx, cli, stack, args.Statefile)
 }
 
 type ZapWriter struct {