Skip to content

Commit f850f43

Browse files
authored
Merge pull request #11 from ctlab/migrate-converters-update-ui
Hotfix converter default compression
2 parents c1b2719 + 63f0e89 commit f850f43

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/main/java/ru/itmo/ctlab/hict/hict_server/handlers/conversion/ConversionHandlersHolder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public void addHandlersToRouter(final @NotNull Router router) {
6969

7070
final var resolutionCsv = req.getParam("resolutions");
7171
final var resolutions = parseResolutions(resolutionCsv);
72-
final var compression = parseInteger(req.getParam("compression"), 0);
72+
final var compression = parseInteger(req.getParam("compression"), 6);
7373
final var compressionAlgorithm = ConversionOptions.CompressionAlgorithm.parse(req.getParam("compressionAlgorithm") == null ? "deflate" : req.getParam("compressionAlgorithm"));
7474
final var chunkSize = parseInteger(req.getParam("chunkSize"), 8192);
7575
final var applyAgpRaw = Boolean.parseBoolean(req.getParam("applyAgp"));
@@ -99,7 +99,7 @@ public void addHandlersToRouter(final @NotNull Router router) {
9999
final var direction = requestJson.getString("direction", "mcool-to-hict");
100100
final var parallelism = requestJson.getInteger("parallelism", Runtime.getRuntime().availableProcessors());
101101
final var resolutions = parseResolutions(requestJson.getString("resolutions"));
102-
final var compression = requestJson.getInteger("compression", 0);
102+
final var compression = requestJson.getInteger("compression", 6);
103103
final var compressionAlgorithm = ConversionOptions.CompressionAlgorithm.parse(requestJson.getString("compressionAlgorithm", "deflate"));
104104
final var chunkSize = requestJson.getInteger("chunkSize", 8192);
105105

@@ -143,7 +143,7 @@ public void addHandlersToRouter(final @NotNull Router router) {
143143
final var parallelJobs = Math.max(1, requestJson.getInteger("parallelJobs", 1));
144144
final var parallelism = requestJson.getInteger("parallelism", Runtime.getRuntime().availableProcessors());
145145
final var resolutions = parseResolutions(requestJson.getString("resolutions"));
146-
final var compression = requestJson.getInteger("compression", 0);
146+
final var compression = requestJson.getInteger("compression", 6);
147147
final var compressionAlgorithm = ConversionOptions.CompressionAlgorithm.parse(requestJson.getString("compressionAlgorithm", "deflate"));
148148
final var chunkSize = requestJson.getInteger("chunkSize", 8192);
149149

src/main/java/ru/itmo/ctlab/hict/hict_server/tools/ConversionCliLauncher.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public static void main(String[] args) throws Exception {
2929
Path.of(parser.require("output")),
3030
parser.listOfLong("resolutions"),
3131
parser.integer("chunk-size", 8192),
32-
parser.integer("compression", 0),
32+
parser.integer("compression", 6),
3333
ConversionOptions.CompressionAlgorithm.parse(parser.value("compression-algorithm", "deflate")),
3434
parser.value("agp", ConversionOptions.NO_AGP),
3535
parser.flag("apply-agp"),
@@ -54,8 +54,8 @@ private static Consumer<String> stdoutLogger() {
5454

5555
private static void printHelp() {
5656
System.out.println("Usage:");
57-
System.out.println(" hict-to-mcool --input=<in.hict> --output=<out.mcool> [--resolutions=10000,50000] [--compression=0..9] [--compression-algorithm=deflate|zstd|lzf] [--chunk-size=8192] [--agp=foo.agp --apply-agp] [--parallelism=N]");
58-
System.out.println(" mcool-to-hict --input=<in.mcool> --output=<out.hict> [--resolutions=10000,50000] [--compression=0..9] [--compression-algorithm=deflate|zstd|lzf] [--chunk-size=8192] [--parallelism=N]");
57+
System.out.println(" hict-to-mcool --input=<in.hict> --output=<out.mcool> [--resolutions=10000,50000] [--compression=0..9 (default: 6)] [--compression-algorithm=deflate|zstd|lzf] [--chunk-size=8192] [--agp=foo.agp --apply-agp] [--parallelism=N]");
58+
System.out.println(" mcool-to-hict --input=<in.mcool> --output=<out.hict> [--resolutions=10000,50000] [--compression=0..9 (default: 6)] [--compression-algorithm=deflate|zstd|lzf] [--chunk-size=8192] [--parallelism=N]");
5959
}
6060

6161
private record ArgParser(String[] args) {

src/main/java/ru/itmo/ctlab/hict/hict_server/tools/HictCli.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ abstract static class BaseConvert implements Callable<Integer> {
122122
@Option(names = "--chunk-size", defaultValue = "8192", description = "HDF5 chunk size (default: 8192).")
123123
int chunkSize;
124124

125-
@Option(names = "--compression", defaultValue = "0", description = "Compression level 0..9 (default: 0).")
125+
@Option(names = "--compression", defaultValue = "6", description = "Compression level 0..9 (default: 6).")
126126
int compression;
127127

128128
@Option(

0 commit comments

Comments
 (0)