fix(amazonq): duplicate hover for project scans aws#4866

Problem
Duplicate hover and code actions are appearing for project scans because only the active file's issues are getting replaced.

Solution
Update every security recommendation by file path instead of only the active file.

Author: ctlai95

packages/core/src/codewhisperer/commands/startSecurityScan.ts

@@ -269,8 +269,8 @@ export function showSecurityScanResults(
             void vscode.commands.executeCommand('workbench.action.problems.focus')
         }
     }
-    populateCodeScanLogStream(zipMetadata.scannedFiles)
     if (scope === CodeWhispererConstants.CodeAnalysisScope.PROJECT) {
+        populateCodeScanLogStream(zipMetadata.scannedFiles)
         showScanCompletedNotification(totalIssues, zipMetadata.scannedFiles, false)
     }
 }

packages/core/src/codewhisperer/service/diagnosticsProvider.ts

@@ -36,19 +36,18 @@ export function initSecurityScanRender(
     }
     securityRecommendationList.forEach(securityRecommendation => {
         updateSecurityDiagnosticCollection(securityRecommendation)
+        updateSecurityIssueHoverAndCodeActions(securityRecommendation)
     })
     securityScanRender.initialized = true
-    updateSecurityIssueHoverAndCodeActions(securityRecommendationList, editor)
     securityScanRender.lastUpdated = codeScanStartTime
 }
 
-function updateSecurityIssueHoverAndCodeActions(
-    securityRecommendationList: AggregatedCodeScanIssue[],
-    editor: vscode.TextEditor
-) {
+function updateSecurityIssueHoverAndCodeActions(securityRecommendation: AggregatedCodeScanIssue) {
     const updatedSecurityRecommendationList = [
-        ...SecurityIssueHoverProvider.instance.issues.filter(group => group.filePath !== editor.document.uri.fsPath),
-        ...securityRecommendationList,
+        ...SecurityIssueHoverProvider.instance.issues.filter(
+            group => group.filePath !== securityRecommendation.filePath
+        ),
+        securityRecommendation,
     ]
     SecurityIssueHoverProvider.instance.issues = updatedSecurityRecommendationList
     SecurityIssueCodeActionProvider.instance.issues = updatedSecurityRecommendationList